fix(devices): clarify offline alert and heartbeat stale states#166
fix(devices): clarify offline alert and heartbeat stale states#166mislayming wants to merge 2 commits into
Conversation
# Conflicts: # web/src/pages/Edges.tsx
|
这个方向可以:把 但这个 PR 需要先 rebase / 重做一下。我们最近已经调整过设备列表页面,现在列表是 Device-first:页面主数据来自 建议改法:
另外这是 UI 行为调整,后续类似 PR 麻烦带上涉及页面的截图,至少包括设备列表状态列的 before/after。这个改动用户一眼就会看到,截图能让 review 更快判断文案、颜色、状态优先级是不是对。 |
|
Reviewed. I would not merge this as-is. The branch is now dirty against main and edits the old Devices/Edges page surface. Since main has moved further toward a Device-first list and Edge-operation wording, this will conflict with the current UI model. Please rebase and update the implementation against the current page, then include screenshots for the affected Devices states: normal online, stale heartbeat, and offline alert. The status helper idea is still useful; it just needs to land on the current UI baseline. |
Summary
device_offlinealerts over tunnel status.Offline alertandHeartbeat stalestates on the Devices page so operators do not see a misleading plain Online state while Alerts reports the device offline.Validation
cd web && npm run test -- deviceStatus.test.tscd web && npm run typecheckcd web && npm run buildcd web && npx eslint src/lib/deviceStatus.ts src/lib/deviceStatus.test.ts src/pages/Edges.tsx --ext ts,tsx --report-unused-disable-directivespasses with 0 errors and 1 existing warning inEdges.tsx.cd web && npm run lintstill fails on pre-existing unrelated repo issues such assrc/api/chat.ts,src/components/ChatInput.tsx,src/components/MessageBubble.tsx,src/pages/DeviceShell.tsx, andsrc/pages/SkillRun.tsx.Author confirmation