Skip to content

fix(build/#3769) Fix npm watch command#3770

Merged
bryphe merged 2 commits into
onivim:masterfrom
eEQK:master
Jul 20, 2021
Merged

fix(build/#3769) Fix npm watch command#3770
bryphe merged 2 commits into
onivim:masterfrom
eEQK:master

Conversation

@eEQK
Copy link
Copy Markdown
Contributor

@eEQK eEQK commented Jul 15, 2021

Fixes #3769

To be honest I'm not sure whether it was broken or just didn't work on my pc. Hoping it's the first scenario, I've decided to submit a PR.

Also, should this PR be included in CHANGES_CURRENT.md?

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jul 15, 2021

CLA assistant check
All committers have signed the CLA.

@bryphe
Copy link
Copy Markdown
Member

bryphe commented Jul 15, 2021

Thanks for the PR @eEQK !

To be honest I'm not sure whether it was broken or just didn't work on my pc. Hoping it's the first scenario, I've decided to submit a PR.

Nice catch, it actually was broken. Missed updating the command when bringing over tree-sitter & vterm (ie, #3555 ). Appreciate the fix!

Also, should this PR be included in CHANGES_CURRENT.md?

For sure, we have an Infrastructure section for build / CI related improvements. Just added it 👍

@bryphe bryphe merged commit 7543be2 into onivim:master Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

npm run watch command fails

3 participants