refactor(symfony-upgrade): update command signatures, replace obsolet…

Command/PullCommand.php

@@ -49,12 +49,14 @@ protected function getCommandDescription(): string
         return self::COMMAND_DESCRIPTION;
     }
 
-    protected function execute(InputInterface $input, OutputInterface $output): void
+    protected function execute(InputInterface $input, OutputInterface $output): int
     {
         $this->handlePullDisplay($output);
         $this->translationService->pull(
             $input->getOption('filePath'),
             $input->getOption('locale')
         );
+
+        return 0;
     }
 }

Command/PushCommand.php

@@ -49,12 +49,14 @@ protected function getCommandDescription(): string
         return self::COMMAND_DESCRIPTION;
     }
 
-    protected function execute(InputInterface $input, OutputInterface $output): void
+    protected function execute(InputInterface $input, OutputInterface $output): int
     {
         $this->handlePushDisplay($output);
         $this->translationService->push(
             $input->getOption('filePath'),
             $input->getOption('locale')
         );
+
+        return 0;
     }
 }

Command/UpdateCommand.php

@@ -40,11 +40,13 @@ protected function getCommandDescription(): string
         return self::COMMAND_DESCRIPTION;
     }
 
-    protected function execute(InputInterface $input, OutputInterface $output): void
+    protected function execute(InputInterface $input, OutputInterface $output): int
     {
         $output->writeln("<info>Updating translations</info>\n");
         $this->handlePullDisplay($output);
         $this->handlePushDisplay($output);
         $this->translationService->update();
+
+        return 0;
     }
 }

Resources/config/services.xml

@@ -36,7 +36,7 @@
                 <argument type="string">%openclassrooms_onesky.file_format%</argument>
             </call>
             <call method="setKernelRootDir">
-                <argument type="string">%kernel.root_dir%</argument>
+                <argument type="string">%kernel.project_dir%</argument>
             </call>
             <call method="setProjectId">
                 <argument type="string">%openclassrooms_onesky.project_id%</argument>

Tests/Command/CommandTestCase.php

@@ -40,7 +40,7 @@ protected function getContainer()
                 'openclassrooms_onesky.file_paths' => [self::$filePaths],
                 'openclassrooms_onesky.requestedLocales' => self::$locales,
                 'openclassrooms_onesky.project_id' => self::$projectId,
-                'kernel.root_dir' => __DIR__.'/../',
+                'kernel.project_dir' => __DIR__.'/../',
             ],
             [
                 'openclassrooms.onesky.services.language_service' => new LanguageServiceMock(),

Tests/DependencyInjection/OpenClassroomsOneSkyExtensionTest.php

@@ -27,7 +27,7 @@ public function container_compile()
 
         $bundle->build($container);
 
-        $container->setParameter('kernel.root_dir', __DIR__.'/../../');
+        $container->setParameter('kernel.project_dir', __DIR__.'/../../');
         $container->compile();
         $this->assertTrue($container->isFrozen());
     }