Skip to content

[QNN EP] Repackage Windows artifacts with signed libs#396

Open
qti-mbadnara wants to merge 27 commits into
mainfrom
dev/qti-mbadnara/repackage-artifacts-with-signed-libs
Open

[QNN EP] Repackage Windows artifacts with signed libs#396
qti-mbadnara wants to merge 27 commits into
mainfrom
dev/qti-mbadnara/repackage-artifacts-with-signed-libs

Conversation

@qti-mbadnara
Copy link
Copy Markdown
Collaborator

@qti-mbadnara qti-mbadnara commented May 16, 2026

This PR makes the change to add the option to repackage the Windows artifacts with the signed DLLs across Wheel, Zip and NuGet as part of the release pipeline. This workflow is triggered as part of .github/workflows/qualcomm-internal-upload-artifactory.yml when the --sign_artifact argument is set as True.

Requirements before running the workflow to repackage the artifacts

  • JFROG_API_KEY
  • The signed libs uploaded as a zip for the corresponding artifact under the zip-project, (e.g) <VERSION>/signed_libs/wheel.zip

@qti-mbadnara
Copy link
Copy Markdown
Collaborator Author

Workflow to repackage Wheels with signed libs: https://github.com/onnxruntime/onnxruntime-qnn/actions/runs/25979405863

Workflow to repackage NuGet with signed libs: https://github.com/onnxruntime/onnxruntime-qnn/actions/runs/25979432108

Workflow to repackage Zip with signed libs: https://github.com/onnxruntime/onnxruntime-qnn/actions/runs/25979456817

@qti-mbadnara
Copy link
Copy Markdown
Collaborator Author

@kuanyul-qti @huaychou Can you help review this PR please!

@kuanyul-qti
Copy link
Copy Markdown
Collaborator

Before reviewing the code, how do you plan to meet the requirement - "The signed libs uploaded as a zip for the corresponding artifact under the zip-test-project: /signed_libs/wheel.zip"?
BTW, the signed_libs should be uploaded to zip-project rather than zip-test-project.

Comment thread .github/workflows/qualcomm-internal-upload-artifactory.yml Outdated
Comment thread qcom/scripts/upleveling/qnn_ep_uplevel.py Outdated
Comment thread .github/workflows/qualcomm-internal-upload-artifactory.yml Outdated
Comment thread qcom/scripts/upleveling/qnn_ep_uplevel.py Outdated
Comment thread qcom/scripts/upleveling/qnn_ep_uplevel.py
Comment thread qcom/scripts/upleveling/qnn_ep_uplevel.py Outdated
Comment thread qcom/scripts/upleveling/qnn_ep_uplevel.py Outdated
@qti-mbadnara
Copy link
Copy Markdown
Collaborator Author

qti-mbadnara commented May 19, 2026

Before reviewing the code, how do you plan to meet the requirement - "The signed libs uploaded as a zip for the corresponding artifact under the zip-test-project: /signed_libs/wheel.zip"? BTW, the signed_libs should be uploaded to zip-project rather than zip-test-project.

For now the libs need to be uploaded manually to the artifactory, but very soon changes will be made to automate that process, though that will take some time. This change is needed for upcoming releases

Changes were made to publish the signed_libs to aisw-zip-project

@qti-mbadnara
Copy link
Copy Markdown
Collaborator Author

Workflow to repackage Wheels with signed libs: https://github.com/onnxruntime/onnxruntime-qnn/actions/runs/26134927557

Workflow to repackage NuGet with signed libs: https://github.com/onnxruntime/onnxruntime-qnn/actions/runs/26134990594

Workflow to repackage Zip with signed libs: https://github.com/onnxruntime/onnxruntime-qnn/actions/runs/26135044254

Comment thread qcom/scripts/upleveling/qnn_ep_uplevel.py Outdated
Comment thread qcom/scripts/upleveling/qnn_ep_uplevel.py Outdated
Comment thread qcom/scripts/upleveling/qnn_ep_uplevel.py Outdated
Comment thread qcom/scripts/upleveling/qnn_ep_uplevel.py Outdated
Comment thread qcom/scripts/upleveling/qnn_ep_uplevel.py Outdated
Comment thread qcom/scripts/upleveling/qnn_ep_uplevel.py
Comment thread qcom/scripts/upleveling/qnn_ep_uplevel.py Outdated
Comment thread qcom/scripts/upleveling/qnn_ep_uplevel.py Outdated
Comment thread qcom/scripts/upleveling/qnn_ep_uplevel.py Outdated
Copy link
Copy Markdown
Collaborator

@huaychou huaychou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do we need to trigger workflow to validate it?

Comment thread qcom/scripts/upleveling/qnn_ep_uplevel.py
Comment thread qcom/scripts/upleveling/qnn_ep_uplevel.py Outdated
Comment thread qcom/scripts/upleveling/qnn_ep_uplevel.py Outdated
Comment thread qcom/scripts/upleveling/qnn_ep_uplevel.py Outdated
Comment thread qcom/scripts/upleveling/qnn_ep_uplevel.py Outdated
Comment thread qcom/scripts/upleveling/qnn_ep_uplevel.py Outdated
Comment thread qcom/scripts/upleveling/qnn_ep_uplevel.py
Comment thread qcom/scripts/upleveling/qnn_ep_uplevel.py
Comment thread qcom/scripts/upleveling/qnn_ep_uplevel.py Outdated
Comment thread qcom/scripts/upleveling/qnn_ep_uplevel.py Outdated
Comment thread qcom/scripts/upleveling/qnn_ep_uplevel.py Outdated
@qti-mbadnara
Copy link
Copy Markdown
Collaborator Author

LGTM. Do we need to trigger workflow to validate it?

I think it should be fine!

Comment thread qcom/scripts/upleveling/qnn_ep_uplevel.py Outdated
Comment thread qcom/scripts/upleveling/qnn_ep_uplevel.py Outdated
Comment thread qcom/scripts/upleveling/qnn_ep_uplevel.py
@qti-mbadnara qti-mbadnara requested a review from kuanyul-qti May 21, 2026 18:10
qti-mbadnara and others added 6 commits May 21, 2026 11:20
Co-authored-by: kuanyul-qti <kuanyul@qti.qualcomm.com>
Signed-off-by: qti-mbadnara <mbadnara@qti.qualcomm.com>
Co-authored-by: kuanyul-qti <kuanyul@qti.qualcomm.com>
Signed-off-by: qti-mbadnara <mbadnara@qti.qualcomm.com>
Co-authored-by: kuanyul-qti <kuanyul@qti.qualcomm.com>
Signed-off-by: qti-mbadnara <mbadnara@qti.qualcomm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants