Multiple Upload Functionality#15
Open
onuridrisoglu wants to merge 3 commits into
Open
Conversation
marciopd
requested changes
Dec 22, 2017
marciopd
left a comment
marciopd
left a comment
Collaborator
There was a problem hiding this comment.
Just a few comments, all the rest looks good.
| downloader.extend(link); | ||
| layout.addComponent(link); | ||
| commentsUpdated(); | ||
| public void componentEvent(Event event) { |
Collaborator
There was a problem hiding this comment.
Is componentEvent method being used?
Owner
Author
There was a problem hiding this comment.
yep, since ReportDetailView implements Component.Listener, it is used whenever a component added or removed from the container
|
|
||
| @Override | ||
| public void updateProgress(long readBytes, long contentLength) { | ||
| uploadProgress.setValue(((float)readBytes)/(float)contentLength); |
Collaborator
There was a problem hiding this comment.
Is formatting missing here?
| package org.vaadin.bugrap.ui; | ||
|
|
||
| public class UploadTrackerModel { | ||
| public static final String FILEUPLOAD_PATH = "/Users/onuridrisoglu/Downloads/temp/"; |
Collaborator
There was a problem hiding this comment.
This directory only exists in your machine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.