Skip to content

chore(ci): add quality-checks workflow + pre-commit#391

Merged
jmelahman merged 5 commits into
mainfrom
kanban/documentation/chore-add-ci-quality-checks
May 13, 2026
Merged

chore(ci): add quality-checks workflow + pre-commit#391
jmelahman merged 5 commits into
mainfrom
kanban/documentation/chore-add-ci-quality-checks

Conversation

@jmelahman
Copy link
Copy Markdown
Contributor

Summary

  • Adds .github/workflows/quality-checks.yml: a docs-focused trim of the standard Onyx quality-checks workflow. Triggers on PR / push(main) / merge_group. Steps: checkout → setup-python 3.11 → j178/prek-action (with --from-ref/--to-ref diff logic on PR + merge_group, --all-files on main) → giner/check-actions. Drops the node/terraform/uv setup steps since nothing here needs them.
  • Adds .pre-commit-config.yaml with: check-added-large-files (10MB — existing screenshots run up to ~9MB, so 1500kb from the reference would have been too aggressive), actionlint, prettier (JSON + CSS only — MDX intentionally excluded so prettier doesn't fight scripts/format_docs.py), ripsecrets, and a local format_docs.py --check --paths hook on changed .md/.mdx files. Upstream hooks pinned to the same SHAs the reference uses.
  • Reformats 9 MDX files via scripts/format_docs.py --write so the new check passes on main. Pure line-wrap/whitespace; no content edits.

Skipped from the reference (not applicable to a docs-only repo): uv-sync/uv-lock/uv-export (no pyproject.toml/uv.lock), golangci-lint, terraform-fmt, shellcheck, npm-install*, typescript-check, ruff/black/ty (only one Python script, not worth the tooling).

Test plan

  • First CI run on this PR is green (prek runs over base..head diff).
  • After merge, the push: branches: main run with --all-files is green.
  • check-actions passes against .github/workflows/quality-checks.yml.
  • Touch an unrelated MDX file in a follow-up PR and confirm format_docs.py hook runs on just that file.

🤖 Generated with Claude Code

jmelahman and others added 3 commits April 28, 2026 08:32
Adds a docs-focused subset of the Onyx quality-checks workflow.
Pre-commit runs format_docs.py on changed MDX, prettier on JSON/CSS,
actionlint, ripsecrets, and a large-files guard (10MB to fit the
existing asset profile). CI runs prek (PR diff / merge_group diff /
--all-files on main) plus check-actions.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Pure line-wrap/whitespace changes produced by running
`python scripts/format_docs.py --write`. No content edits.
Required so the newly-added format_docs.py pre-commit hook
passes on main with --all-files.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@mintlify
Copy link
Copy Markdown

mintlify Bot commented May 13, 2026

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
onyx 🟢 Ready View Preview May 13, 2026, 11:19 PM

💡 Tip: Enable Workflows to automatically generate PRs for you.

jmelahman and others added 2 commits May 13, 2026 23:24
The v3.1.0/v3.2.0 entries merged from main don't match
format_docs.py's wrap rules; CI catches them because
actions/checkout checks out the PR merge ref.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@jmelahman jmelahman merged commit 0219a91 into main May 13, 2026
4 checks passed
@jmelahman jmelahman deleted the kanban/documentation/chore-add-ci-quality-checks branch May 13, 2026 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants