feat(sessions): Long-lived sandbox sessions#28
Closed
Danelegend wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want the ability to create long living sandbox sessions. Currently we only allow ephemeral sessions where the sandbox is stood up, files are uploaded + code is ran, and then the sandbox is stood down.
There are some use cases that will make multiple calls to one session, hence it doesn't make sense to keep spinning up and down these sessions. Let's make them long-lived. They require a TTL so that they get cleaned up however.
This PR introduces the creation and deletion of these sessions, as well as cleanup logic to tear them down.