refactor(executors): extract reusable primitives#29
Merged
Conversation
… work Pure refactor - no behavior change. Existing test suite passes unmodified. * `DockerExecutor._build_run_command` now takes `sleep_seconds` and an optional `labels` mapping, so future callers can spin up containers with custom durations and label sets. * `DockerExecutor._create_tar_archive`'s `code` argument is now optional, letting callers stage files without an entrypoint. * `_upload_tar_to_container` extracted from `_stage_files_in_container` for reuse. * `KubernetesExecutor._create_pod_manifest` is parameterized over `command`, `labels`, `annotations`, and `active_deadline_seconds`. * `KubernetesExecutor._create_tar_archive` mirrors the Docker change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… work
Pure refactor - no behavior change. Existing test suite passes unmodified.
DockerExecutor._build_run_commandnow takessleep_secondsand an optionallabelsmapping, so future callers can spin up containers with custom durations and label sets.DockerExecutor._create_tar_archive'scodeargument is now optional, letting callers stage files without an entrypoint._upload_tar_to_containerextracted from_stage_files_in_containerfor reuse.KubernetesExecutor._create_pod_manifestis parameterized overcommand,labels,annotations, andactive_deadline_seconds.KubernetesExecutor._create_tar_archivemirrors the Docker change.