Skip to content

chore: audit(2026-05) phase 2a slice 12: extract licensing concern#1436

Open
ooples wants to merge 1 commit into
audit/2026-05-phase2a-slice4-compliancefrom
audit/2026-05-phase2a-slice12-license
Open

chore: audit(2026-05) phase 2a slice 12: extract licensing concern#1436
ooples wants to merge 1 commit into
audit/2026-05-phase2a-slice4-compliancefrom
audit/2026-05-phase2a-slice12-license

Conversation

@ooples
Copy link
Copy Markdown
Owner

@ooples ooples commented May 23, 2026

Stacked on #1435. Extracts ConfigureLicenseKey into internal IAiModelLicensing (internal because LicenseValidator is internal). Both ctors initialise the component with their optional licenseKey; ConfigureLicenseKey resets the cached validator on key change (preserves pre-refactor side-effect verbatim). 5/5 tests pass, both TFMs clean.

🤖 Generated with Claude Code

…delBuilder

Stacked on slice 4 (#1435). Extracts ConfigureLicenseKey into internal IAiModelLicensing component. Both constructors now initialise the component with their optional licenseKey parameter; ConfigureLicenseKey resets the cached validator on key change (verbatim pre-refactor semantics). Component is internal because LicenseValidator is internal — InternalsVisibleTo on AiDotNet.Tests lets tests still reach it. 5/5 component tests pass.
@vercel
Copy link
Copy Markdown

vercel Bot commented May 23, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
aidotnet_website Ready Ready Preview, Comment May 23, 2026 4:05am

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 23, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 0812dbad-d592-463d-9f78-d906633866fe

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch audit/2026-05-phase2a-slice12-license

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot changed the title audit(2026-05) phase 2a slice 12: extract licensing concern chore: audit(2026-05) phase 2a slice 12: extract licensing concern May 23, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🤖 PR Title Auto-Fixed

Your PR title was automatically updated to follow Conventional Commits format.

Original title:
audit(2026-05) phase 2a slice 12: extract licensing concern

New title:
chore: audit(2026-05) phase 2a slice 12: extract licensing concern

Detected type: chore: (default type)
Version impact: No release


Valid types and their effects:

  • feat: - New feature (MINOR bump: 0.1.0 → 0.2.0)
  • fix: - Bug fix (MINOR bump)
  • docs: - Documentation (MINOR bump)
  • refactor: - Code refactoring (MINOR bump)
  • perf: - Performance improvement (MINOR bump)
  • test: - Tests only (no release)
  • chore: - Build/tooling (no release)
  • ci: - CI/CD changes (no release)
  • style: - Code formatting (no release)
  • deps: - Dependency update (no release)

If the detected type is incorrect, you can manually edit the PR title.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant