Fix duplicate update in callees#366
Merged
Merged
Conversation
johannesduesing
added
bug
Collaborator
|
The latter is a known issue: #357 |
Collaborator
Author
|
As discussed in person, i've reverted the configuration change to be addressed in a separate issue. |
errt
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a duplicate, irrelevant call to
updateWithfor the direct callees inCallees.scala. I tried to test the performance improvement resulting from this, but found no measurable impact when running theCallGraphIntegrationTestmultiple times. I did, however, see errors when loading the TypeBasedReflectionAllocationsAnalysisScheduler- an additionalAnalysisSchedulerwas appended to the class name before reflectively locating the class, which resulted in a ClassNotFoundException. Using the fully qualified name in the configuration, the error disappeared.