Conversation
Contributor
|
I can’t test it at the moment. I only have one board and it’s currently used in production, so it’s difficult for me to run tests right now. However, I should receive new ones in the coming days/weeks, but I’ll need to set up the whole setup beforehand. |
Collaborator
Author
|
@gdesor No urgent need to test from our side. But do keep on the radar that you should check this before using it in production. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR mainly fixes two issues related to the client.
@gdesor I'm not assigning this to you for review, but please do check this PR hasn't broken your custom detectors. (It should be fine, but I do not have these devices to properly test myself.)