docs: use latest version in installation#843
Open
reshnm wants to merge 1 commit intoopen-component-model:mainfrom
Open
docs: use latest version in installation#843reshnm wants to merge 1 commit intoopen-component-model:mainfrom
reshnm wants to merge 1 commit intoopen-component-model:mainfrom
Conversation
Updated installation command to use the latest version of ocm-controller. Signed-off-by: René Schünemann <rene.schuenemann@sap.com>
frewilhelm
reviewed
Feb 23, 2026
Contributor
frewilhelm
left a comment
frewilhelm
left a comment
There was a problem hiding this comment.
just one minor proposal :)
|
|
||
| ```bash | ||
| helm install ocm-controller oci://ghcr.io/open-component-model/helm/ocm-controller --version v0.25.3 | ||
| OCM_CONTROLLER_LATEST_VERSION=$(curl -s https://api.github.com/repos/open-component-model/ocm-controller/releases/latest | grep '"tag_name":' | sed -E 's/.*"([^"]+)".*/\1/') |
Contributor
There was a problem hiding this comment.
Suggested change
| OCM_CONTROLLER_LATEST_VERSION=$(curl -s https://api.github.com/repos/open-component-model/ocm-controller/releases/latest | grep '"tag_name":' | sed -E 's/.*"([^"]+)".*/\1/') | |
| OCM_CONTROLLER_LATEST_VERSION=$(curl -s https://api.github.com/repos/open-component-model/ocm-controller/releases/latest | jq -r '.tag_name') |
Although I really love some sed action, I think using jq is simpler (however, it would be another dependency)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated installation command to use the latest version of ocm-controller.
The docs currently statically reference and old version.
An alternative approach would be to update the docs when a new version has been released, but I think this is simpler.
What this PR does / why we need it
Which issue(s) this PR is related to