Skip to content

fix: update flux api version CR#846

Merged
frewilhelm merged 2 commits intoopen-component-model:mainfrom
frewilhelm:update-api-version-flux
Feb 26, 2026
Merged

fix: update flux api version CR#846
frewilhelm merged 2 commits intoopen-component-model:mainfrom
frewilhelm:update-api-version-flux

Conversation

@frewilhelm
Copy link
Contributor

Flux deprecated their CR source.toolkit.fluxcd.io/v1beta2. Now source.toolkit.fluxcd.io/v1 is required.

Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
@frewilhelm frewilhelm requested a review from a team as a code owner February 25, 2026 06:41
morri-son
morri-son previously approved these changes Feb 25, 2026
@morri-son
Copy link
Contributor

@frewilhelm the e2e tests fail. I guess this change need to be propagetd through multiple places:

=== RUN   TestHelmChartResource/Configure_Management_Repository
Handling connection for 3000
    helm_test.go:82: successfully created repository at url http://localhost:3000/e2e-tester/ocm-controller-helm-test.git
    helm_test.go:82: Created token secret flux-system/ocm-controller-helm-test
    helm_test.go:82: no matches for kind "GitRepository" in version "source.toolkit.fluxcd.io/v1beta2"

@frewilhelm
Copy link
Contributor Author

This is still failing. I need to check it locally. Probably need to push some changes to another repository

@morri-son morri-son dismissed their stale review February 25, 2026 08:44

Didn't check the e2e test results

@frewilhelm
Copy link
Contributor Author

ocm-e2e-framework imports an old version from flux. I think I might update this to make it work

@Skarlso Skarlso self-assigned this Feb 25, 2026
@Skarlso
Copy link
Contributor

Skarlso commented Feb 25, 2026

Got it.

PASS
ok      github.com/open-component-model/ocm-controller/e2e      232.229s

DONE 65 tests in 232.234s

I'll push in a second.

On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com>

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@frewilhelm frewilhelm merged commit ab77285 into open-component-model:main Feb 26, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants