Conversation
Co-authored-by: Duncan Dewhurst <duncan.dewhurst@opendataservices.coop>
Co-authored-by: Duncan Dewhurst <duncan.dewhurst@opendataservices.coop>
Co-authored-by: Duncan Dewhurst <duncan.dewhurst@opendataservices.coop>
|
Thank you, @duncandewhurst, for the changes. I think this is ready for James to review again, right? |
Yes! |
There was a problem hiding this comment.
I rewrote change_history_options per the discussion here: #1531 (comment)
That page now uses "full updates" to mean "full updates in the context of a change history" – in contrast to incremental updates. It also uses "individual releases" to mean "individual releases, when you can't publish a change history" – in contrast to "compiled releases".
However, that usage is inconsistent with the other pages.
I suggest renaming the other pages:
- Incremental updates -> Change history. As Duncan commented, the examples are a mix of full and incremental updates. In any case, we don't have a page for each of these (and I don't think we need one, as the distinction is fairly minor).
- Full updates -> Individual releases with no change history
- No change history -> Compiled releases with no change history
To be clear, if a publisher follows the 'easy releases' approach, then they aren't publishing a change history (at best, a third-party can reconstruct a change history).
There might need to be some corresponding changes to the introductory paragraphs on those other pages.
|
@yolile, @jpmckinney are you happy for me to pick up and complete this PR? |
|
@duncandewhurst Yes, I'm! |
|
To-do:
|
|
@jpmckinney this is ready for your review. I've made the changes suggested in your last comment, simplified the examples in line with our discussions elsewhere, and made various copy edits for consistency and clarity. Two things to flag:
Edit: I forgot to mention, this PR includes some commits from #1661 which is also awaiting review. Whichever is reviewed first, I'll make the necessary updates to the other one. |
Agree - I prefer your suggested simplification. |
|
Great. I've done that in c848382 |
…s due to removal of "status")
|
Noting that amendments.md includes changes from #1661, but my suggested edits in that PR don't overlap, so there shouldn't be a merge conflict. amendments.md has an extra commits in this PR, which can be reviewed independently:
|
Closes #1412