Skip to content

Feeds Generate Atom IDs Implement #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JVickery-TBS wants to merge 2 commits into
base: canada-v2.10
Choose a base branch
from
Open

Feeds Generate Atom IDs Implement #232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f54485
feat(dev): feeds implement;
JVickery-TBS Jun 23, 2026
80fcb07
feat(misc): changelog;
JVickery-TBS Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/232.canada.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Added a `create_atom_id` implement method to the `IFeed` implement class. This allows for plugins to customize the generation of Atom entry IDs.
7 changes: 7 additions & 0 deletions ckan/plugins/interfaces.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,13 @@ def get_item_additional_fields(
"""
return {}

# (canada fork only): add feed id gen implement method
# TODO: upstream contrib!!
def create_atom_id(self, atom_id: str, resource_path: str,
authority_name: Optional[str] = None,
date_string: Optional[str] = None) -> str:
pass


class IResourceUrlChange(Interface):
u'''
Expand Down
10 changes: 9 additions & 1 deletion ckan/views/feed.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -836,8 +836,16 @@ def _create_atom_id(resource_path: str,
return u''.join([site_url, resource_path])

tagging_entity = u','.join([authority_name, date_string])
return u':'.join(['tag', tagging_entity, resource_path])
# (canada fork only): add feed id gen implement method
# TODO: upstream contrib!!
atom_id = ':'.join(['tag', tagging_entity, resource_path])

for plugin in plugins.PluginImplementations(plugins.IFeed):
if hasattr(plugin, 'create_atom_id'):
atom_id = plugin.create_atom_id(
atom_id, resource_path, authority_name, date_string)

return atom_id

# Routing
# (canada fork only): custom single dataset feed
Expand Down
Loading