STAGING ONLY: Grants Monthly#1525
Open
RabiaSajjad wants to merge 42 commits into
Open
Conversation
JVickery-TBS
requested changes
Oct 30, 2024
JVickery-TBS
left a comment
JVickery-TBS
left a comment
Contributor
There was a problem hiding this comment.
Going to make a mock PR soon to see diffs between the templates just to make it easier to review
…ld in grantsmonthly
- Array value for example.
- Include grants monthly prep.
# Conflicts: # ckanext/canada/i18n/ckanext-canada.pot # ckanext/canada/i18n/en/LC_MESSAGES/ckanext-canada.po # ckanext/canada/i18n/fr/LC_MESSAGES/ckanext-canada.po ### RESOLVED.
- `text` -> `_text` - Added test class for grants monthly.
JVickery-TBS
changed the title
- Flake8 fixes.
# Conflicts: # ckanext/canada/i18n/ckanext-canada.pot # ckanext/canada/i18n/en/LC_MESSAGES/ckanext-canada.po # ckanext/canada/i18n/fr/LC_MESSAGES/ckanext-canada.po ### RESOLVED.
wardi
requested changes
Oct 31, 2025
wardi
left a comment
wardi
left a comment
Member
There was a problem hiding this comment.
enforced validation (trigger) for the new fields hasn't been implemented yet, and a few small comments/wishlist items above
| The "Recipient postal code" is a mandatory field that serves to identify the specific area in which the recipient operates. In cases where this field cannot be populated this field may be left blank. | ||
|
|
||
| Text format locked to "X#X #X#"; The Canada Post tool for looking up a postal code can be found on the Canada Post website. | ||
| Should be in the format "A1A 1A1"; The Canada Post tool for looking up a postal code can be found on the Canada Post website. |
Member
There was a problem hiding this comment.
Definitely sad if users are expected to input these one at a time into the canada post website. We should have bulk geocoding tools that fill these in automatically and validate addresses at the same time.
| fr: Numéro de la circonscription fédérale où réside le bénéficiaire. Les départements peuvent consulter le site-web d’Élections Canada pour trouver le numéro de la circonscription fédérale. http://www.elections.ca/content.aspx?section=res&dir=cir/list&document=index338&lang=f | ||
| obligation: Optional | ||
| format_type: Free text | ||
| en: The federal riding number is based on the riding in which the recipient resides. Departments can consult the Elections Canada website in order to retrieve the federal riding number. http://www.elections.ca/content.aspx?section=res&dir=cir/list&document=index338&lang=e |
Member
There was a problem hiding this comment.
Same here re:obviously missing geocoding tools
Comment on lines
+222
to
+224
| LEN({cell})-LEN(SUBSTITUTE({cell},"-",""))>0, | ||
| LEN({cell})-LEN(SUBSTITUTE({cell},".",""))>0, | ||
| LEN({cell})-LEN(SUBSTITUTE({cell},",",""))>0 |
Member
There was a problem hiding this comment.
these could be one check instead of 3, like:
LEN({cell})-LEN(
SUBSTITUTE(SUBSTITUTE(SUBSTITUTE({cell},",",""),".",""),"-","")
)>0
| excel_required_formula: 'AND(NOT(ISBLANK({agreement_start_date})),VALUE({agreement_start_date})>=DATE(2025,11,1))' | ||
| datastore_type: text | ||
| form_attrs: | ||
| size: 60 |
Member
There was a problem hiding this comment.
do you want to make the excel column width larger too?
| validation: | ||
| en: | | ||
| This field must not be empty. | ||
| Date can’t be in the future. |
# Conflicts: # ckanext/canada/i18n/ckanext-canada.pot # ckanext/canada/i18n/en/LC_MESSAGES/ckanext-canada.po # ckanext/canada/i18n/fr/LC_MESSAGES/ckanext-canada.po # ckanext/canada/tests/test_grants.py ### RESOLVED.
# Conflicts: # ckanext/canada/i18n/ckanext-canada.pot # ckanext/canada/i18n/en/LC_MESSAGES/ckanext-canada.po # ckanext/canada/i18n/fr/LC_MESSAGES/ckanext-canada.po ### RESOLVED.
- Added js evals for the Grants Pilot pd type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mock PR for diff of table definition: #1526