Skip to content

eui: Add TextBoxEx header#4

Open
guymakinggames wants to merge 1 commit intoopen-ead:mainfrom
guymakinggames:TextBoxEx
Open

eui: Add TextBoxEx header#4
guymakinggames wants to merge 1 commit intoopen-ead:mainfrom
guymakinggames:TextBoxEx

Conversation

@guymakinggames
Copy link
Copy Markdown

@guymakinggames guymakinggames commented Apr 14, 2026

This change is Reviewable

@MonsterDruide1 MonsterDruide1 changed the title Eui: Add euiTextBoxEx header eui: Add TextBoxEx header Apr 14, 2026
Copy link
Copy Markdown

@MonsterDruide1 MonsterDruide1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MonsterDruide1 reviewed 1 file and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on guymakinggames).


include/euiTextBoxEx.h line 11 at r1 (raw file):

    u8 _0[0x11c];
    u8 mDirtyFlags;
};

Suggestion:

class TextBoxEx : public nn::ui2d::TextBox {
public:
    // will change accordingly
    u8 _0[0x11c];
    u8 mDirtyFlags;
};

include/euiTextBoxEx.h line 20 at r1 (raw file):

template <>
eui::TextBoxEx* DynamicCast<eui::TextBoxEx*, nn::ui2d::Pane>(nn::ui2d::Pane* pane);
}  // namespace nn::ui2d

You got a jackpot of "missing dependencies":
This one needs a PR to nnheaders as well, as nn::ui2d should be listed in that repo instead.
https://github.com/open-ead/nnheaders

Suggestion:

namespace nn::ui2d {
template <typename T, typename U>
T DynamicCast(U* pane);
}  // namespace nn::ui2d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants