Skip to content

util: Fix iterators of BitArray and IntrusiveList#60

Merged
MonsterDruide1 merged 2 commits intoopen-ead:masterfrom
MonsterDruide1:bitarray-iterator
Mar 31, 2026
Merged

util: Fix iterators of BitArray and IntrusiveList#60
MonsterDruide1 merged 2 commits intoopen-ead:masterfrom
MonsterDruide1:bitarray-iterator

Conversation

@MonsterDruide1
Copy link
Copy Markdown

@MonsterDruide1 MonsterDruide1 commented Mar 17, 2026

Currently, a line like this causes cryptic error messages:
nn::util::BitArray::const_reverse_iterator it = arr.rbegin();

After two hours of debugging and working with C++ iterators, I found a fix: Declaring more of the elements required to build iterator_trait, and changing them to public to allow accessing them outside.


This change is Reviewable

@MonsterDruide1 MonsterDruide1 self-assigned this Mar 17, 2026
@MonsterDruide1 MonsterDruide1 changed the title util: Fix BitArray::reverse_iterators util: Fix iterators of BitArray and IntrusiveList Mar 17, 2026
Copy link
Copy Markdown
Collaborator

@ThePixelGamer ThePixelGamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ThePixelGamer reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on MonsterDruide1).

@MonsterDruide1 MonsterDruide1 merged commit 708c140 into open-ead:master Mar 31, 2026
2 checks passed
@MonsterDruide1 MonsterDruide1 deleted the bitarray-iterator branch March 31, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants