fix: remove if-wrappers from error flags#369
Merged
Conversation
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
4ddeaeb to
52752bf
Compare
There was a problem hiding this comment.
Code Review
This pull request refactors the flag configuration files by simplifying the targeting logic, specifically removing redundant 'if' wrappers and directly defining conditions like 'sem_ver', 'fractional', and string operators. It also updates the variants for fractional flags to better match their bucket configurations. I have no feedback to provide.
beeme1mr
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ifwrappers were added in #356 (my bad), but json-logic'sifcoerces its condition to a boolean;nullandfalseare both falsy, so theifalways selects the"false"variant for both cases. This makes it impossible to verify that operators returnnull(notfalse) on error, which is the entire point of the@operator-errorsscenarios.By using the operator directly as the top-level targeting expression, a
nullreturn propagates to the evaluator, which falls back todefaultVariantwith reasonDEFAULT; afalsereturn would resolve to the"false"variant with reasonTARGETING_MATCH. The distinction is preserved.I tested this locally and with this and the expected fixes, I was able to get the test suite fully updated in in-process mode! No more inconsistencies!