Skip to content

fix(flipt): Fix FliptProvider to honor server default variant when match is false #1776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Openroads wants to merge 2 commits into
base: main
Choose a base branch
from
+32 −3
Open

fix(flipt): Fix FliptProvider to honor server default variant when match is false #1776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3c9940
fix(flipt): Fix FliptProvider to honor server default variant when th…
Apr 17, 2026
2f67900
fix(flipt): Update FliptProvider to set original reason if there is n…
Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions providers/flipt/src/main/java/dev/openfeature/contrib/providers/flipt/FliptProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,8 +178,8 @@ private <T> ProviderEvaluation<Value> evaluateVariant(
log.error("Error evaluating variant", e);
throw new GeneralError(e.getMessage());
}

if (!response.isMatch()) {
boolean hasVariantKey = response.getVariantKey() != null && !response.getVariantKey().isEmpty();
if (!response.isMatch() && !hasVariantKey) {
Comment thread
Openroads marked this conversation as resolved.
log.debug("non matching variant for {} : {}", key, response.getReason());
return ProviderEvaluation.<Value>builder()
.value(defaultValue)
Expand All @@ -201,7 +201,7 @@ private <T> ProviderEvaluation<Value> evaluateVariant(
return ProviderEvaluation.<Value>builder()
.value(value)
.variant(response.getVariantKey())
.reason(TARGETING_MATCH.name())
.reason(response.isMatch() ? TARGETING_MATCH.name() : response.getReason().toString())
.flagMetadata(flagMetadataBuilder.build())
.build();
}
Expand Down
19 changes: 19 additions & 0 deletions providers/flipt/src/test/java/dev/openfeature/contrib/providers/flipt/FliptProviderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,25 @@ void getStringVariantEvaluation() {
assertEquals("fallback_str", client.getStringValue("non-existing", "fallback_str", evaluationContext));
}

@Test
void getStringVariantEvaluation_usesServerDefaultVariantWhenNoMatch() {
// Flipt returns match=false but still returns a variantKey (server default variant).
mockFliptAPI("/evaluate/v1/variant", "variant-default-nomatch.json", VARIANT_FLAG_NAME);

MutableContext evaluationContext = new MutableContext();
evaluationContext.setTargetingKey(TARGETING_KEY);

// SDK defaultValue should NOT be used in this case; server default variant should win.
ProviderEvaluation<String> evaluation =
fliptProvider.getStringEvaluation(VARIANT_FLAG_NAME, "sdk-fallback", evaluationContext);

assertEquals("server-default", evaluation.getValue());
assertEquals("server-default", evaluation.getVariant());

// Also verify the OpenFeature client path.
assertEquals("server-default", client.getStringValue(VARIANT_FLAG_NAME, "sdk-fallback", evaluationContext));
}

@Test
void getIntegerEvaluation() {
mockFliptAPI("/evaluate/v1/variant", "variant-int.json", INT_FLAG_NAME);
Expand Down
10 changes: 10 additions & 0 deletions providers/flipt/src/test/resources/variant-default-nomatch.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"match": false,
"reason": "DEFAULT_EVALUATION_REASON",
"requestDurationMillis": 1,
"requestId": "string",
"segmentKeys": [],
"timestamp": "2022-12-03T10:15:30+01:00",
"variantAttachment": "",
"variantKey": "server-default"
}
Loading