Skip to content

fix: freeze ClientMetadata to satisfy spec req 4.2.2.1 #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cristiangmarta wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: freeze ClientMetadata to satisfy spec req 4.2.2.1 #273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/open_feature/sdk/client_metadata.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ module OpenFeature
module SDK
ClientMetadata = Struct.new(:domain, keyword_init: true) do
alias_method :name, :domain

def initialize(domain: nil)
super(domain: domain&.dup&.freeze)
freeze
end
end
end
end
5 changes: 5 additions & 0 deletions spec/open_feature/sdk/client_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,11 @@
expect(client).to respond_to(:metadata)
expect(client.metadata.domain).to eq(domain)
end

it "client metadata is frozen (req 4.2.2.1 — hook context client_metadata must be immutable)" do
expect(client.metadata).to be_frozen
Comment thread
cristiangmarta marked this conversation as resolved.
expect(client.metadata.domain).to be_frozen
end
Comment thread
cristiangmarta marked this conversation as resolved.
end

context "Flag evaluation" do
Expand Down