-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Fixes #26775: Use empty default for OIDC_CUSTOM_PARAMS to fix Compose brace-parsing #26965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
75f2f98
21d5f96
06c18c5
bf9aee2
30336b3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -119,7 +119,7 @@ services: | |||||
| OIDC_CLIENT_AUTH_METHOD: ${OIDC_CLIENT_AUTH_METHOD:-"client_secret_post"} | ||||||
| OIDC_TENANT: ${OIDC_TENANT:-""} | ||||||
| OIDC_MAX_CLOCK_SKEW: ${OIDC_MAX_CLOCK_SKEW:-""} | ||||||
| OIDC_CUSTOM_PARAMS: ${OIDC_CUSTOM_PARAMS:-{}} | ||||||
| OIDC_CUSTOM_PARAMS: ${OIDC_CUSTOM_PARAMS:-} | ||||||
|
||||||
| OIDC_CUSTOM_PARAMS: ${OIDC_CUSTOM_PARAMS:-} | |
| OIDC_CUSTOM_PARAMS: "${OIDC_CUSTOM_PARAMS:-""}" |
Copilot
AI
Apr 26, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same issue as earlier in the file: ${OIDC_CUSTOM_PARAMS:-} is unquoted; unset can become YAML null (Compose pass-through/omit), and {...} values can be parsed as YAML maps. Quote the interpolation or use an explicit empty-string default to keep the env var value a string.
| OIDC_CUSTOM_PARAMS: ${OIDC_CUSTOM_PARAMS:-} | |
| OIDC_CUSTOM_PARAMS: "${OIDC_CUSTOM_PARAMS:-}" |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -119,7 +119,7 @@ services: | |||||
| OIDC_CLIENT_AUTH_METHOD: ${OIDC_CLIENT_AUTH_METHOD:-"client_secret_post"} | ||||||
| OIDC_TENANT: ${OIDC_TENANT:-""} | ||||||
| OIDC_MAX_CLOCK_SKEW: ${OIDC_MAX_CLOCK_SKEW:-""} | ||||||
| OIDC_CUSTOM_PARAMS: ${OIDC_CUSTOM_PARAMS:-{}} | ||||||
| OIDC_CUSTOM_PARAMS: ${OIDC_CUSTOM_PARAMS:-} | ||||||
|
||||||
| OIDC_CUSTOM_PARAMS: ${OIDC_CUSTOM_PARAMS:-} | |
| OIDC_CUSTOM_PARAMS: "${OIDC_CUSTOM_PARAMS:-""}" |
Copilot
AI
Apr 26, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same issue as earlier in the file: leaving ${OIDC_CUSTOM_PARAMS:-} unquoted can resolve to YAML null when unset and can be parsed as a YAML map for {...} values. Quote the interpolation or default explicitly to an empty string so the container consistently receives a string.
| OIDC_CUSTOM_PARAMS: ${OIDC_CUSTOM_PARAMS:-} | |
| OIDC_CUSTOM_PARAMS: "${OIDC_CUSTOM_PARAMS:-""}" |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -118,7 +118,7 @@ services: | |||||
| OIDC_CLIENT_AUTH_METHOD: ${OIDC_CLIENT_AUTH_METHOD:-"client_secret_post"} | ||||||
| OIDC_TENANT: ${OIDC_TENANT:-""} | ||||||
| OIDC_MAX_CLOCK_SKEW: ${OIDC_MAX_CLOCK_SKEW:-""} | ||||||
| OIDC_CUSTOM_PARAMS: ${OIDC_CUSTOM_PARAMS:-{}} | ||||||
| OIDC_CUSTOM_PARAMS: ${OIDC_CUSTOM_PARAMS:-} | ||||||
|
||||||
| OIDC_CUSTOM_PARAMS: ${OIDC_CUSTOM_PARAMS:-} | |
| OIDC_CUSTOM_PARAMS: ${OIDC_CUSTOM_PARAMS:-""} |
Copilot
AI
Apr 26, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same issue as earlier in the file: ${OIDC_CUSTOM_PARAMS:-} is unquoted, which can produce YAML null when unset and YAML map typing when set to {...}. Quote the interpolation or use an explicit empty-string default to ensure Compose passes a string env var value.
| OIDC_CUSTOM_PARAMS: ${OIDC_CUSTOM_PARAMS:-} | |
| OIDC_CUSTOM_PARAMS: "${OIDC_CUSTOM_PARAMS:-""}" |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -115,7 +115,7 @@ services: | |||||
| OIDC_CLIENT_AUTH_METHOD: ${OIDC_CLIENT_AUTH_METHOD:-"client_secret_post"} | ||||||
| OIDC_TENANT: ${OIDC_TENANT:-""} | ||||||
| OIDC_MAX_CLOCK_SKEW: ${OIDC_MAX_CLOCK_SKEW:-""} | ||||||
| OIDC_CUSTOM_PARAMS: ${OIDC_CUSTOM_PARAMS:-{}} | ||||||
| OIDC_CUSTOM_PARAMS: ${OIDC_CUSTOM_PARAMS:-} | ||||||
|
||||||
| OIDC_CUSTOM_PARAMS: ${OIDC_CUSTOM_PARAMS:-} | |
| OIDC_CUSTOM_PARAMS: "${OIDC_CUSTOM_PARAMS:-""}" |
Copilot
AI
Apr 26, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same issue as earlier in the file: unquoted ${OIDC_CUSTOM_PARAMS:-} can become YAML null when unset (Compose pass-through/omit) and can be parsed as a YAML map if set to {...}. Quote the interpolation or use an explicit empty-string default so the env var stays a string.
| OIDC_CUSTOM_PARAMS: ${OIDC_CUSTOM_PARAMS:-} | |
| OIDC_CUSTOM_PARAMS: "${OIDC_CUSTOM_PARAMS:-""}" |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -60,7 +60,7 @@ services: | |||||
| OIDC_CLIENT_AUTH_METHOD: ${OIDC_CLIENT_AUTH_METHOD:-"client_secret_post"} | ||||||
| OIDC_TENANT: ${OIDC_TENANT:-""} | ||||||
| OIDC_MAX_CLOCK_SKEW: ${OIDC_MAX_CLOCK_SKEW:-""} | ||||||
| OIDC_CUSTOM_PARAMS: ${OIDC_CUSTOM_PARAMS:-{}} | ||||||
| OIDC_CUSTOM_PARAMS: ${OIDC_CUSTOM_PARAMS:-} | ||||||
|
||||||
| OIDC_CUSTOM_PARAMS: ${OIDC_CUSTOM_PARAMS:-} | |
| OIDC_CUSTOM_PARAMS: "${OIDC_CUSTOM_PARAMS:-}" |
Copilot
AI
Apr 26, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same issue as earlier in the file: ${OIDC_CUSTOM_PARAMS:-} is unquoted, so unset resolves to YAML null (Compose pass-through/omit) and {...} values can be parsed as YAML maps. Quote the interpolation or use an explicit empty-string default to guarantee a string env var value.
| OIDC_CUSTOM_PARAMS: ${OIDC_CUSTOM_PARAMS:-} | |
| OIDC_CUSTOM_PARAMS: ${OIDC_CUSTOM_PARAMS:-""} |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -108,7 +108,7 @@ services: | |||||
| OIDC_CLIENT_AUTH_METHOD: ${OIDC_CLIENT_AUTH_METHOD:-"client_secret_post"} | ||||||
| OIDC_TENANT: ${OIDC_TENANT:-""} | ||||||
| OIDC_MAX_CLOCK_SKEW: ${OIDC_MAX_CLOCK_SKEW:-""} | ||||||
| OIDC_CUSTOM_PARAMS: ${OIDC_CUSTOM_PARAMS:-{}} | ||||||
| OIDC_CUSTOM_PARAMS: ${OIDC_CUSTOM_PARAMS:-} | ||||||
|
||||||
| OIDC_CUSTOM_PARAMS: ${OIDC_CUSTOM_PARAMS:-} | |
| OIDC_CUSTOM_PARAMS: "${OIDC_CUSTOM_PARAMS:-""}" |
Copilot
AI
Apr 26, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same issue as earlier in the file: the unquoted ${OIDC_CUSTOM_PARAMS:-} can resolve to YAML null when unset and can be parsed as a YAML map if the value is {...}. Quote the interpolation or use an explicit empty-string default so Compose consistently treats this as a string env var value.
| OIDC_CUSTOM_PARAMS: ${OIDC_CUSTOM_PARAMS:-} | |
| OIDC_CUSTOM_PARAMS: ${OIDC_CUSTOM_PARAMS:-""} |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -148,7 +148,7 @@ services: | |||||
| OIDC_CLIENT_AUTH_METHOD: ${OIDC_CLIENT_AUTH_METHOD:-"client_secret_post"} | ||||||
| OIDC_TENANT: ${OIDC_TENANT:-""} | ||||||
| OIDC_MAX_CLOCK_SKEW: ${OIDC_MAX_CLOCK_SKEW:-""} | ||||||
| OIDC_CUSTOM_PARAMS: ${OIDC_CUSTOM_PARAMS:-{}} | ||||||
| OIDC_CUSTOM_PARAMS: ${OIDC_CUSTOM_PARAMS:-} | ||||||
|
||||||
| OIDC_CUSTOM_PARAMS: ${OIDC_CUSTOM_PARAMS:-} | |
| OIDC_CUSTOM_PARAMS: ${OIDC_CUSTOM_PARAMS:-""} |
Copilot
AI
Apr 26, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same issue as earlier in the file: leaving ${OIDC_CUSTOM_PARAMS:-} unquoted can yield YAML null when unset and YAML map typing when set to {...}. Quote the interpolation or default explicitly to an empty string to keep the env var consistently a string.
| OIDC_CUSTOM_PARAMS: ${OIDC_CUSTOM_PARAMS:-} | |
| OIDC_CUSTOM_PARAMS: ${OIDC_CUSTOM_PARAMS:-""} |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -106,7 +106,7 @@ services: | |||||
| OIDC_CLIENT_AUTH_METHOD: ${OIDC_CLIENT_AUTH_METHOD:-"client_secret_post"} | ||||||
| OIDC_TENANT: ${OIDC_TENANT:-""} | ||||||
| OIDC_MAX_CLOCK_SKEW: ${OIDC_MAX_CLOCK_SKEW:-""} | ||||||
| OIDC_CUSTOM_PARAMS: ${OIDC_CUSTOM_PARAMS:-{}} | ||||||
| OIDC_CUSTOM_PARAMS: ${OIDC_CUSTOM_PARAMS:-} | ||||||
|
||||||
| OIDC_CUSTOM_PARAMS: ${OIDC_CUSTOM_PARAMS:-} | |
| OIDC_CUSTOM_PARAMS: "${OIDC_CUSTOM_PARAMS:-}" |
Copilot
AI
Apr 26, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same issue as earlier in the file: this unquoted ${OIDC_CUSTOM_PARAMS:-} can become YAML null when unset and can be parsed as a YAML map when set to {...}, which can lead to Compose pass-through/omit semantics or unexpected stringification. Quote the interpolation or use an explicit empty-string default to ensure a string env var value.
| OIDC_CUSTOM_PARAMS: ${OIDC_CUSTOM_PARAMS:-} | |
| OIDC_CUSTOM_PARAMS: ${OIDC_CUSTOM_PARAMS:-""} |
Uh oh!
There was an error while loading. Please reload this page.