fix(quickstart): quote OIDC default to prevent compose brace-parsing crash (#26775)#27011
Conversation
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
There was a problem hiding this comment.
Pull request overview
This PR hardens the Docker Compose quickstart/development/OpenMetadata compose variants by quoting the empty-object default for OIDC_CUSTOM_PARAMS, preventing Compose variable-expansion from misparsing {} and producing invalid server configuration (per #26775).
Changes:
- Updated
OIDC_CUSTOM_PARAMSdefaults from${OIDC_CUSTOM_PARAMS:-{}}to${OIDC_CUSTOM_PARAMS:-"{}"}across compose variants. - Kept the intended semantic default as an empty JSON object.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| docker/docker-compose-quickstart/docker-compose.yml | Quote OIDC_CUSTOM_PARAMS default to avoid {} interpolation misparse in quickstart compose. |
| docker/docker-compose-quickstart/docker-compose-rdf.yml | Same quoting fix for the RDF quickstart compose variant. |
| docker/docker-compose-quickstart/docker-compose-postgres.yml | Same quoting fix for the Postgres quickstart compose variant. |
| docker/docker-compose-openmetadata/docker-compose-openmetadata.yml | Same quoting fix for the OpenMetadata compose variant. |
| docker/development/docker-compose.yml | Same quoting fix for the development compose variant. |
| docker/development/docker-compose-postgres.yml | Same quoting fix for the development Postgres compose variant. |
| docker/development/docker-compose-postgres-fuseki.yml | Same quoting fix for the Fuseki-enabled development compose variant. |
| docker/development/docker-compose-gcp.yml | Same quoting fix for the GCP development compose variant. |
…en-metadata#26775) Use single quotes instead of double quotes to avoid escaping issues and pass clean JSON object {} to the application instead of string "{}"
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
Code Review ✅ ApprovedAdds single quotes around OIDC_CUSTOM_PARAMS default value in the quickstart configuration to prevent Docker Compose from misinterpreting braces as variable substitution syntax. No issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
|
Hi @SaaiAravindhRaja, thanks for your pr here! We had a PR submitted for this already here. Please make sure that you are assigned an issue and that there is not a PR out for it already before submitting something. We will reopen this PR if necessary. |
Summary
Quotes the empty-object default for
OIDC_CUSTOM_PARAMSin the Docker compose files so Compose does not misparse{}during variable expansion.OIDC_CUSTOM_PARAMSTest Plan
docker compose -f docker/docker-compose-quickstart/docker-compose.yml configdocker compose -f docker/docker-compose-openmetadata/docker-compose-openmetadata.yml config