Skip to content

fix(quickstart): quote OIDC default to prevent compose brace-parsing crash (#26775)#27011

Closed
SaaiAravindhRaja wants to merge 3 commits intoopen-metadata:mainfrom
SaaiAravindhRaja:fix/issue-26775-quickstart-oidc-brace-fix
Closed

fix(quickstart): quote OIDC default to prevent compose brace-parsing crash (#26775)#27011
SaaiAravindhRaja wants to merge 3 commits intoopen-metadata:mainfrom
SaaiAravindhRaja:fix/issue-26775-quickstart-oidc-brace-fix

Conversation

@SaaiAravindhRaja
Copy link
Copy Markdown
Contributor

Summary

Quotes the empty-object default for OIDC_CUSTOM_PARAMS in the Docker compose files so Compose does not misparse {} during variable expansion.

  • updates all quickstart, development, and openmetadata compose variants that expose OIDC_CUSTOM_PARAMS
  • keeps the default semantic value as an empty JSON object
  • resolves Issues with QuickStart #26775

Test Plan

  • docker compose -f docker/docker-compose-quickstart/docker-compose.yml config
  • docker compose -f docker/docker-compose-openmetadata/docker-compose-openmetadata.yml config

Copilot AI review requested due to automatic review settings April 3, 2026 06:55
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 3, 2026

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR hardens the Docker Compose quickstart/development/OpenMetadata compose variants by quoting the empty-object default for OIDC_CUSTOM_PARAMS, preventing Compose variable-expansion from misparsing {} and producing invalid server configuration (per #26775).

Changes:

  • Updated OIDC_CUSTOM_PARAMS defaults from ${OIDC_CUSTOM_PARAMS:-{}} to ${OIDC_CUSTOM_PARAMS:-"{}"} across compose variants.
  • Kept the intended semantic default as an empty JSON object.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
docker/docker-compose-quickstart/docker-compose.yml Quote OIDC_CUSTOM_PARAMS default to avoid {} interpolation misparse in quickstart compose.
docker/docker-compose-quickstart/docker-compose-rdf.yml Same quoting fix for the RDF quickstart compose variant.
docker/docker-compose-quickstart/docker-compose-postgres.yml Same quoting fix for the Postgres quickstart compose variant.
docker/docker-compose-openmetadata/docker-compose-openmetadata.yml Same quoting fix for the OpenMetadata compose variant.
docker/development/docker-compose.yml Same quoting fix for the development compose variant.
docker/development/docker-compose-postgres.yml Same quoting fix for the development Postgres compose variant.
docker/development/docker-compose-postgres-fuseki.yml Same quoting fix for the Fuseki-enabled development compose variant.
docker/development/docker-compose-gcp.yml Same quoting fix for the GCP development compose variant.

@SaaiAravindhRaja SaaiAravindhRaja marked this pull request as draft April 4, 2026 05:35
…en-metadata#26775)

Use single quotes instead of double quotes to avoid escaping issues
and pass clean JSON object {} to the application instead of string "{}"
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 4, 2026

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@SaaiAravindhRaja SaaiAravindhRaja marked this pull request as ready for review April 4, 2026 11:16
Copilot AI review requested due to automatic review settings April 4, 2026 11:16
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 4, 2026

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented Apr 4, 2026

Code Review ✅ Approved

Adds single quotes around OIDC_CUSTOM_PARAMS default value in the quickstart configuration to prevent Docker Compose from misinterpreting braces as variable substitution syntax. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.

@PubChimps
Copy link
Copy Markdown
Contributor

Hi @SaaiAravindhRaja, thanks for your pr here! We had a PR submitted for this already here. Please make sure that you are assigned an issue and that there is not a PR out for it already before submitting something. We will reopen this PR if necessary.

@PubChimps PubChimps closed this Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issues with QuickStart

3 participants