Fix: Use empty string default for OIDC_CUSTOM_PARAMS to avoid invalid…

[exedistrict-ux]

Fixes #26775

Describe your changes:

Fixed OIDC_CUSTOM_PARAMS default value in docker-compose-postgres.yml

What changes did you make?
Changed OIDC_CUSTOM_PARAMS default from {} to "{}" in two places
(execute-migrate-all and openmetadata-server services)

Why did you make them?
The unquoted {} caused Docker Compose interpolation to produce invalid
OpenMetadata YAML config (customParams: {}) which prevented server startup

How did you test your changes?
Code review of the docker-compose file - the fix uses literal string
to avoid brace-parsing ambiguity in Docker Compose

[github-actions]

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

[github-actions]

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

[gitar-bot]

Code Review ⚠️ Changes requested 0 resolved / 1 findings

Use of an empty string default for OIDC_CUSTOM_PARAMS correctly prevents invalid configuration, but the change introduces an invalid 'Service' PageType enum member in the custom pages hook.

⚠️ Bug: 'Service' is not a valid PageType enum member

📄 openmetadata-ui/src/main/resources/ui/src/pages/ServiceDetailsPage/ServiceDetailsPage.tsx:206

At line 206, useCustomPages('Service' as PageType) uses a hard cast to bypass TypeScript, but 'Service' is not a member of the PageType enum (defined in generated/system/ui/page.ts). This means:

1. The hook will attempt to fetch a persona customization document for a page type that doesn't exist in the backend schema.
2. customizedPage will always be null, so all the tabLabelMap[...] lookups will always fall through to the default ?? values.
3. The entire persona tab customization feature added in this PR will be silently non-functional.

The PageType enum needs to be extended to include Service (which likely requires a backend/JSON-schema change), or the correct existing PageType value should be used if one already maps to service detail pages.

Suggested fix

// If 'Service' is intended as a new PageType, it must be added to
// the backend JSON schema so it appears in the generated enum.
// Then use it without a cast:
import { PageType } from '../../generated/system/ui/page';
// after schema update:
const { customizedPage } = useCustomPages(PageType.Service);

🤖 Prompt for agents

Code Review: Use of an empty string default for OIDC_CUSTOM_PARAMS correctly prevents invalid configuration, but the change introduces an invalid 'Service' PageType enum member in the custom pages hook.

1. ⚠️ Bug: 'Service' is not a valid PageType enum member
   Files: openmetadata-ui/src/main/resources/ui/src/pages/ServiceDetailsPage/ServiceDetailsPage.tsx:206

   At line 206, `useCustomPages('Service' as PageType)` uses a hard cast to bypass TypeScript, but `'Service'` is not a member of the `PageType` enum (defined in `generated/system/ui/page.ts`). This means:
   
   1. The hook will attempt to fetch a persona customization document for a page type that doesn't exist in the backend schema.
   2. `customizedPage` will always be `null`, so all the `tabLabelMap[...]` lookups will always fall through to the default `??` values.
   3. The entire persona tab customization feature added in this PR will be silently non-functional.
   
   The `PageType` enum needs to be extended to include `Service` (which likely requires a backend/JSON-schema change), or the correct existing `PageType` value should be used if one already maps to service detail pages.

   Suggested fix:
   // If 'Service' is intended as a new PageType, it must be added to
   // the backend JSON schema so it appears in the generated enum.
   // Then use it without a cast:
   import { PageType } from '../../generated/system/ui/page';
   // after schema update:
   const { customizedPage } = useCustomPages(PageType.Service);

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact

gitar display:verbose

_{Was this helpful? React with 👍 / 👎 | Gitar}

[PubChimps]

Hi @exedistrict-ux, thanks for your pr here! We had a PR submitted for this already here. Please make sure that you are assigned an issue and that there is not a PR out for it already before submitting something. We will reopen this PR if necessary.