-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Fixes #26970: fix bot name search on the Bots page #27365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
siddhiguptas
wants to merge
33
commits into
open-metadata:main
Choose a base branch
from
siddhiguptas:fix/bots-page-name-search
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
2979813
Fix bot name matching on the Bots page search
siddhiguptas a3d6165
Fixes #26970: migrate Bots search to API-based name/email lookup with…
siddhiguptas 925d005
Fix flaky Playwright setup by making Table/User creation idempotent a…
siddhiguptas 8ee2155
Merge branch 'main' into fix/bots-page-name-search
siddhiguptas 9c0d085
Fixes #26970: avoid full bot scan by switching search result resoluti…
siddhiguptas f78b4f3
Merge branch 'fix/bots-page-name-search' of https://github.com/siddhi…
siddhiguptas 339804f
Fixes #26970: align bot user search with deleted toggle and tighten t…
siddhiguptas 324c3d6
Fixes #26970: keep bot search API-driven, align wildcard matching wit…
siddhiguptas 2ed61b3
fix: stabilize bot search behavior and flaky Playwright flows across …
siddhiguptas 2f6bbfc
fix: limit PR scope to bot search by reverting unrelated Tour Playwri…
siddhiguptas ac54692
Merge branch 'main' into fix/bots-page-name-search
harsh-vador ce64825
fix: remove unrelated Playwright changes and keep bot search scope fo…
siddhiguptas e8802bc
Merge branch 'fix/bots-page-name-search' of https://github.com/siddhi…
siddhiguptas 774f59b
fix: optimize bot search scalability with paginated user-index retrie…
siddhiguptas 392e98f
Merge branch 'main' into fix/bots-page-name-search
siddhiguptas d2e68dc
fix: harden Bots API search with bounded pagination/concurrency and c…
siddhiguptas 0c150f5
Merge branch 'fix/bots-page-name-search' of https://github.com/siddhi…
siddhiguptas 9bed9d3
fix: prevent stale bot search state and strengthen Bots Playwright co…
siddhiguptas 8716fb2
test: scope Playwright fixes to bot flow and remove unrelated test ch…
siddhiguptas 0956671
Add local bot search and stabilize tests
siddhiguptas edf3496
Fixes: keep Bot search API-driven for complete results and stabilize …
siddhiguptas 1ec1666
chore: revert out-of-scope bot Playwright test changes
siddhiguptas d61e5df
test: add bot search e2e coverage and tighten bot API response assert…
siddhiguptas 9482345
test: stabilize bot search no-match assertions using filter placehold…
siddhiguptas 9b4f6c0
fix: add search API wait in bot Playwright flow and refactor bot-user…
siddhiguptas eac9242
fix: extract reusable searchbar helper with search API wait and dedup…
siddhiguptas d43b9db
Merge branch 'main' into fix/bots-page-name-search
siddhiguptas 6d254bc
Merge branch 'main' into fix/bots-page-name-search
harsh-vador 0d75ae2
fix(playwright): make bot search test stable by removing brittle API …
siddhiguptas 08c3f0f
Merge branch 'fix/bots-page-name-search' of https://github.com/siddhi…
siddhiguptas 13fbb21
Refactor bot search integration and Playwright synchronization for re…
siddhiguptas 3f51664
Fix bot search regressions by preserving getBotByName compatibility e…
siddhiguptas e6b17aa
fix: stabilize bot search Playwright API wait to prevent encoded-quer…
siddhiguptas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -198,6 +198,53 @@ export const clickOutside = async (page: Page) => { | |
| }); | ||
| }; | ||
|
|
||
| export const updateSearchInputAndWait = async ( | ||
| page: Page, | ||
| searchInput: Locator, | ||
| value: string | ||
| ) => { | ||
| await searchInput.clear(); | ||
| await searchInput.fill(value); | ||
| await expect(searchInput).toHaveValue(value); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. integrate the search api get api here as well |
||
| await waitForAllLoadersToDisappear(page); | ||
| }; | ||
|
|
||
| type SearchInputOptions = { | ||
| waitForSearchApi?: boolean; | ||
| searchApiPattern?: string; | ||
| }; | ||
|
|
||
| export const searchFromSearchInput = async ( | ||
| page: Page, | ||
| searchInput: Locator, | ||
| searchTerm: string, | ||
| options: SearchInputOptions = {} | ||
| ) => { | ||
| const { | ||
| waitForSearchApi = false, | ||
| searchApiPattern = '/api/v1/search/query', | ||
| } = options; | ||
| const normalizedSearchTerm = searchTerm.trim(); | ||
|
|
||
| const searchResponsePromise = | ||
| waitForSearchApi && normalizedSearchTerm | ||
| ? page.waitForResponse( | ||
| (response) => | ||
| response.url().includes(searchApiPattern) && | ||
| response.request().method() === 'GET' | ||
| ) | ||
| : undefined; | ||
|
|
||
| await updateSearchInputAndWait(page, searchInput, searchTerm); | ||
|
|
||
| if (!searchResponsePromise) { | ||
| return; | ||
| } | ||
|
|
||
| const searchResponse = await searchResponsePromise; | ||
| expect(searchResponse.status()).toBe(200); | ||
| }; | ||
|
|
||
| export const visitOwnProfilePage = async (page: Page) => { | ||
| await page.locator('[data-testid="dropdown-profile"] svg').click(); | ||
| await page.locator('[role="menu"].profile-dropdown').waitFor({ | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.