Conversation
| <div className="tw:inline-flex tw:items-center tw:gap-0.5 tw:min-w-0"> | ||
| <Typography.Text | ||
| className={classNames('tw:text-xs', { | ||
| className={classNames('tw:text-xs tw:truncate tw:max-w-32', { |
There was a problem hiding this comment.
💡 Edge Case: Hardcoded tw:max-w-32 may truncate breadcrumbs too aggressively
The breadcrumb text is truncated at tw:max-w-32 (128px) for all items. For deeply nested columns with long names, every breadcrumb segment will be truncated, making it difficult for users to distinguish between similarly-named segments. Consider using a responsive or relative max-width, or allowing the last breadcrumb item (the current column) to have a larger max-width since it's the most relevant.
Suggested fix:
Apply a wider max-width to the last breadcrumb item:
className={classNames('tw:text-xs tw:truncate', {
'tw:max-w-48 tw:cursor-default tw:font-medium tw:text-gray-700': isLastItem,
'tw:max-w-32 tw:cursor-pointer tw:font-normal tw:text-gray-400 hover:tw:underline': !isLastItem,
})}
Was this helpful? React with 👍 / 👎 | Reply gitar fix to apply this suggestion
❌ Lint Check Failed — ESLint + Prettier + Organise Imports (src)The following files have style issues that need to be fixed: Fix locally (fast — only for changed files in the branch): make ui-checkstyle-src-changedOr to fix all files: make ui-checkstyle-src |
🔴 Playwright Results — 1 failure(s), 19 flaky✅ 3953 passed · ❌ 1 failed · 🟡 19 flaky · ⏭️ 86 skipped
Genuine Failures (failed on all attempts)❌
|
Code Review 👍 Approved with suggestions 1 resolved / 2 findingsRefactored the breadcrumb styling to move the inline style to a CSS class. Consider adjusting the hardcoded tw:max-w-32 constraint to prevent overly aggressive text truncation. 💡 Edge Case: Hardcoded tw:max-w-32 may truncate breadcrumbs too aggressivelyThe breadcrumb text is truncated at Suggested fix✅ 1 resolved✅ Quality: Inline style on line 845 should be in CSS class
🤖 Prompt for agentsOptionsDisplay: compact → Showing less information. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
|



Describe your changes:
Fixed the text overflow issues on explore page, classification page sidebar, also fixed the z-index issue in classification page. And updated the tab button type in lineage page.
Also in columnDetailsPanel component both tailwind and bootstrap classes are used, so i have make it consistent.
Fixes
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>Summary by Gitar
ColumnDetailPanel.component.tsx.min-w-0andoverflow-hiddento container elements to resolve text overflow issues.This will update automatically on new commits.