Fixes #27458: Display SQL expression for library DQ tests#27516
Fixes #27458: Display SQL expression for library DQ tests#27516piyushdotcomm wants to merge 8 commits intoopen-metadata:mainfrom
Conversation
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
|
Hi @harshach , could you please add the |
harshach
added
the
safe to test
Jest test CoverageUI tests summary
|
🟡 Playwright Results — all passed (21 flaky)✅ 3953 passed · ❌ 0 failed · 🟡 21 flaky · ⏭️ 86 skipped
🟡 21 flaky test(s) (passed on retry)
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
![gitar-bot[bot]](https://avatars.githubusercontent.com/in/827041?s=60&v=4){kind=small}
piyushdotcomm
force-pushed
the
fix-27458-dq-library-sql-expression
branch
from
90f23d5 to
b492f7b
Compare
piyushdotcomm
requested review from
akash-jain-10,
harshach and
tutte
as code owners
|
Hi @harshach @akash-jain-10 @tutte @anuj-kumary @pmbrull |
|
@ShaileshParmar11 please review and merge it cc @TeddyCr |
|
GlossaryWorkflow.spec.ts and playwright-sso-tests.yml changes are |
ShaileshParmar11
left a comment
ShaileshParmar11
left a comment
There was a problem hiding this comment.
Hi, thank you for the contribution. Could you please attach a video recording or screenshots of the UI changes?
There was a problem hiding this comment.
Can you please help me understand why we need changes in this yml file?
| let entity: Table; | ||
| if (entityResponse.status() === 409) { | ||
| const entityResponseByName = await apiContext.get( | ||
| `/api/v1/tables/name/${encodeURIComponent( | ||
| `${schema.fullyQualifiedName}.${this.entity.name}` | ||
| )}` | ||
| ); | ||
| if (!entityResponseByName.ok()) { | ||
| throw new Error( | ||
| `TableClass: failed to fetch existing table "${ | ||
| this.entity.name | ||
| }" (${entityResponseByName.status()}): ${await entityResponseByName.text()}` | ||
| ); | ||
| } | ||
| entity = await entityResponseByName.json(); | ||
| } else if (!entityResponse.ok()) { |
There was a problem hiding this comment.
We have fixed this issue, so could you please revert this change?
I would recommend keeping this PR focused on issue #27458 and removing the other unrelated changes from it.
| await searchBar.focus(); | ||
| await searchBar.press('Control+a'); | ||
| await searchBar.pressSequentially(searchTerm); |
There was a problem hiding this comment.
please revert this
Code Review ✅ Approved 1 resolved / 1 findingsUpdates library DQ tests to display the underlying SQL expression, successfully resolving the accidental inclusion of a .spec.ts.bak backup file. No further issues identified. ✅ 1 resolved✅ Quality: Backup file .spec.ts.bak accidentally committed to repo
OptionsDisplay: compact → Showing less information. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
Mock the test definition response directly so the limited-permission user does not reuse a failed live response status. Drop the unrelated data-product PATCH status assertion from this PR.
Make table setup retry-safe after partial shard retries, wait for specific Activity API description events, align glossary workflow assertions with the current In Review state, and simplify domain selector search input handling.
Replace unsupported GitHub Actions upper() usage in SSO Playwright secrets and apply the UI checkstyle formatter output for changed Playwright files.
…reviewer feedback
|
3 participants
Fixes #27458
I worked on displaying the SQL expression for library-based Data Quality tests because the test details
page only showed SQL for custom SQL tests. Library tests already expose their SQL template through
TestDefinition.sqlExpression, but the result/details tab was not requesting or rendering that field.Changes made:
TestDefinitionwithparameterDefinitionandsqlExpressionfields in the test case resulttab.
TestDefinition.sqlExpressionisavailable.
TestCase.parameterValues.sqlExpressionwhenpresent.
sqlExpressionfrom the test definition APIType of change:
Checklist:
Fixes <issue-number>: <short explanation>Testing:
playwright test playwright/e2e/Features/DataQuality/TestCaseResultPermissions.spec.ts --listAdded Playwright test:
User with TEST_CASE.VIEW_ALL can view library test SQL expression in UISummary by Gitar
TableClassto implement robust status checks for API responses during entity creation.domain.tsto utilize explicit API response waiting in search and selection workflows for improved test reliability.This will update automatically on new commits.