Conversation
HelgeCD
requested review from
Fannon,
desislavaa,
maiargu,
pavelkornev and
swennemers
|
swennemers
reviewed
Feb 27, 2026
|
|
||
| **Support-Oriented Properties:** | ||
| - Package: `supportInfo` - Primarily for support teams, not end-users | ||
| - Extensible objects: `extensible.description` - Technical information for developers |
Member
There was a problem hiding this comment.
Extensibility should in general move into the end user/key user = business user responsibility and this information is shown in BAH/catalogs, therefore, we should enable translation for this property as well. The information here is necessary for key users to understand, what they need to select in their translated key user extensibility tools.
swennemers
reviewed
Feb 27, 2026
Comment on lines
+48
to
+51
| **Option 1A: Generic JSON Paths** | ||
| - Use JSON Pointer syntax (e.g., `"$.title"`, `"$.shortDescription"`) to target translatable properties | ||
| - More flexible but risks targeting technical fields like `$.version` or `$.ordId` | ||
| - Fragile to schema changes and requires deep ORD structure knowledge |
Member
There was a problem hiding this comment.
can we move this to the rejected options?
swennemers
reviewed
Feb 27, 2026
|
|
||
| **Recommendation**: For the initial implementation, focus on the core translatable properties and defer complex object translation to a future version. | ||
|
|
||
| ## Consequences |
Member
There was a problem hiding this comment.
can we specify the impact and expectations on aggregators and consumers?
Especially:
- Are aggregators expected to return the i18n info embedded into the ord resources to consumers?
- Are consumers able to query with a target language and get texts in the target language with a language fallback? (like browsers/UIs do it)
Member
There was a problem hiding this comment.
do we have aggregements on implementing this with our main aggregators?
swennemers
reviewed
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still a WIP branch.
Before starting any actual implementation I created an ADR based on some SAP internal discussions. Goal is to be able to gather some more feedback before actually starting defining the specification.
Adding the ADR to the repo was aligned with @Fannon. The goal is to be able to understand the design decisions long term and outside the scope of a single PR. Not sure if the current structure is ideal, but I think it is a good starting point.
Next Steps: Gather Feedback (~2 weeks) and refine specification afterwards.