Ontology: Drop Float as a built-in concept#145
Open
jochenchrist wants to merge 1 commit into
Open
Conversation
Float is conceptually the same as Decimal (the most general floating-point/decimal value type), so having both as built-in concepts is redundant. Remove `Float` from the built-in concepts table and update the flights example to use `Decimal` instead. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
jochenchrist
changed the title
khush-bhatia
approved these changes
Jun 5, 2026
Member
|
@kurtStirewalt Could you review as well ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FloatandDecimaldescribe the same thing at the conceptual level: the most general floating-point/decimal value type. Carrying both as separate built-in concepts is redundant and invites ambiguity about which one to extend when modeling a non-integer numeric value type.This PR drops
Floatas a built-in concept and keepsDecimalas the single built-in for non-integer numeric values.Changes
ontology/ontology.md: remove theFloatrow from the built-in concepts table.examples/flights.yaml: update the runwaylengthandshapeLengthmappings (and their verbalizations) to useDecimalinstead ofFloat, so the example still references only declared built-ins.Notes
No JSON schema or validation code enumerated the built-in concepts, so the doc table and the one example were the only references to
Float.