add config support for BaggageSpanProcessor#1330
Conversation
|
@jack-berg @trask please check |
MikeGoldsmith
left a comment
MikeGoldsmith
left a comment
There was a problem hiding this comment.
Looks great, thanks @zeitlinger!
| public class BaggageSpanProcessorCustomizer implements AutoConfigurationCustomizerProvider { | ||
| @Override | ||
| public void customize(AutoConfigurationCustomizer autoConfigurationCustomizer) { | ||
| autoConfigurationCustomizer.addTracerProviderCustomizer( |
There was a problem hiding this comment.
For a moment I thought this wouldn't work because this customizers are applied after the batch exporter is registered, but then I realized that order of registration doesn't matter for span processors which want to take advantage of modifying the span on start.
We would need to make changes in the SDK if this was a BaggageLogRecordProcessor: Either providing a hook to customize the logger provider before batch processor is added, or by extending SdkLoggerProviderBuilder with a method to insert a processor at the front of the queue.
There was a problem hiding this comment.
Either providing a hook to customize the logger provider before batch processor is added
I think this is a great idea - would make sense for all signals
BTW, I've made the test end-to-end to cover that "onStast" is actually called
Co-authored-by: Mike Goldsmith <goldsmith.mike@gmail.com>
...test/java/io/opentelemetry/contrib/baggage/processor/BaggageSpanProcessorCustomizerTest.java
Show resolved
Hide resolved
...src/main/java/io/opentelemetry/contrib/baggage/processor/BaggageSpanProcessorCustomizer.java
Outdated
Show resolved
Hide resolved
5 participants
Add config support for BaggageSpanProcessor to add it to java agent - simply by adding the library.