Fix CI: suppress RepeatedField psalm errors, restore PHP 8.1 support#1965
Fix CI: suppress RepeatedField psalm errors, restore PHP 8.1 support#1965bobstrecansky wants to merge 1 commit into
Conversation
Two issues are currently failing PHP QA on main: 1. Psalm reports 32 UndefinedDocblockClass errors against Google\Protobuf\Internal\RepeatedField on every Otlp converter. google/protobuf 4.x deprecated the Internal class in favor of Google\Protobuf\RepeatedField; the legacy name is now a runtime class_alias that Psalm's static parser cannot see. Add an UndefinedDocblockClass suppression alongside the existing UndefinedMethod suppression for the same class. 2. The PHP 8.1 matrix job fails composer install because phpspec/prophecy 1.26 dropped PHP 8.1 in 1.23 and requires phpdocumentor/reflection-docblock ^6, which itself needs prophecy 1.26. Revert both renovate bumps (open-telemetry#1915, open-telemetry#1919) to the prior constraints so the project's declared "php": "^8.1" support holds. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
One or more co-authors of this pull request were not found. You must specify co-authors in commit message trailer via: Supported
Alternatively, if the co-author should not be included, remove the Please update your commit message(s) by doing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1965 +/- ##
============================================
+ Coverage 67.75% 67.85% +0.09%
Complexity 3044 3044
============================================
Files 459 459
Lines 8883 8885 +2
============================================
+ Hits 6019 6029 +10
+ Misses 2864 2856 -8
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Summary
UndefinedDocblockClasssuppression forGoogle\Protobuf\Internal\RepeatedField(mirrors the existingUndefinedMethodsuppression for the same class). Clears the 32 errors blocking PHP QA on 8.2 / 8.3 / 8.4.composer installon PHP 8.1: pinphpspec/prophecyback to1.22.*(1.23+ dropped PHP 8.1) andphpdocumentor/reflection-docblockback to^5.3(prophecy 1.22 conflicts with v6). Restores the project's declared"php": "^8.1"support.Supersedes #1959 (same psalm fix) and reverts the install-breaking parts of #1915 and #1919.
Test plan
EOF