Skip to content

test(otlp-common): expand test coverage for OTLP common exporter#2075

Open
arjun-rajappa wants to merge 2 commits into
open-telemetry:mainfrom
arjun-rajappa:add-test-to-otlp-common
Open

test(otlp-common): expand test coverage for OTLP common exporter#2075
arjun-rajappa wants to merge 2 commits into
open-telemetry:mainfrom
arjun-rajappa:add-test-to-otlp-common

Conversation

@arjun-rajappa
Copy link
Copy Markdown
Contributor

Closes #1667
Expands test coverage for the OTLP common exporter and adds span flags support per OTLP specification.

Changes
Added build_span_flags method to set remote parent context flags on spans and links
Comprehensive test coverage for all private methods (as_otlp_span, as_otlp_status_code, as_otlp_span_kind, as_otlp_key_value, as_otlp_any_value)
Integration tests for complex spans with multiple resources and scopes
Enhanced error handling tests for encoding issues
Testing
All tests pass. Coverage expanded from basic functionality to comprehensive edge cases.

Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this pull request will be closed eventually by the stale bot

@kaylareopelle
Copy link
Copy Markdown
Contributor

Hi @arjun-rajappa, thanks for your patience with my review. Could you take a look at the failing tests?

@thompson-tomo
Copy link
Copy Markdown
Contributor

@kaylareopelle i have split out the new test cases to a seperate PR #2159 to enable this to be more focussed.

@arjun-rajappa it would be great if you could avoid mixing in format changes as it just ends up making it more time consuming to review.

@arjun-rajappa
Copy link
Copy Markdown
Contributor Author

Hi @arjun-rajappa, thanks for your patience with my review. Could you take a look at the failing tests?

I believe these failures are addressed already in #2074. As these are related to otlp-http. Once the other PR is merged in these should start passing.

@thompson-tomo
Copy link
Copy Markdown
Contributor

I don't think that is the case as our main is passing so a change here is resulting in the failure.

Note common is a dependency of http hence why it is possible a change to common could lead to failures in http.

@arjun-rajappa
Copy link
Copy Markdown
Contributor Author

These changes are closely related, as otlp-http relies on methods defined in otlp-common. As a result, changes to otlp-common can impact the tests in otlp-http. If needed, I can add the changes here or rebase this branch entirely on top of #2074.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make otlp-http, otlp-grpc, and otlp-common gems production-ready

3 participants