metrics: report last value for gauges under cumulative temporality#36
Open
lukashes wants to merge 1 commit into
Open
metrics: report last value for gauges under cumulative temporality#36lukashes wants to merge 1 commit into
lukashes wants to merge 1 commit into
Conversation
Gauge/ObservableGauge are the only kinds whose default aggregation is LastValue, so processCumulativeDataPoints now overwrites instead of accumulating when the instrument kind is a gauge. The decision is made from the measurements' instrument kind already available to the function, keeping process() unaware of the reduction detail.
|
|
jaronoff97
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The temporal aggregator always summed data points on the cumulative path, so a gauge read under cumulative temporality (e.g. via a cumulative-only exporter) accumulated its observations instead of reporting the latest one.
Solution
Gauge/ObservableGauge are the only kinds whose default aggregation is LastValue, so processCumulativeDataPoints now overwrites instead of accumulating when the instrument kind is a gauge.