Skip to content

Make status comment revisions monotonic#140

Closed
trask wants to merge 1 commit into
open-telemetry:mainfrom
trask:fix/monotonic-status-revisions
Closed

Make status comment revisions monotonic#140
trask wants to merge 1 commit into
open-telemetry:mainfrom
trask:fix/monotonic-status-revisions

Conversation

@trask

@trask trask commented Jul 22, 2026

Copy link
Copy Markdown
Member

Prevent queued workers with an older status-comment renderer from publishing against or mutating a newer rollout. New revisions can initialize rollout state, equal revisions can resume it, and older revisions exit without GitHub writes or state changes.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Ensures status-comment rollouts remain monotonic across queued workers using different renderer revisions.

Changes:

  • Preserves rollout state created by newer renderer revisions.
  • Prevents stale workers from publishing comments or mutating rollout state.
  • Adds regression tests for both behaviors.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/scripts/pull-request-dashboard/pr_status_comment.py Adds stale-revision detection and preserves newer rollout state.
.github/scripts/pull-request-dashboard/test_pr_status_comment.py Tests stale-worker suppression and state preservation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Jul 22, 2026

Copy link
Copy Markdown

Pull request dashboard status

Status last refreshed: 2026-07-22 22:08:11 UTC.

  • Status: Closed.

This automated status or its linked feedback items may be incorrect. If something looks wrong, please report it with the result you expected.

@trask
trask marked this pull request as ready for review July 22, 2026 18:29
@trask
trask requested a review from a team as a code owner July 22, 2026 18:29
@trask
trask requested a review from adrielp July 22, 2026 18:29
@trask

trask commented Jul 22, 2026

Copy link
Copy Markdown
Member Author

Superseded by a replacement that uses an explicit dashboard delivery revision to coordinate stale-worker rejection across delivery state and behavior.

@trask trask closed this Jul 22, 2026
@trask

trask commented Jul 22, 2026

Copy link
Copy Markdown
Member Author

Replacement: #144

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants