detect cluster ingress in helm2#69
Open
maire-kehoe wants to merge 3 commits intoopen-toolchain:masterfrom
Open
detect cluster ingress in helm2#69maire-kehoe wants to merge 3 commits intoopen-toolchain:masterfrom
maire-kehoe wants to merge 3 commits intoopen-toolchain:masterfrom
Conversation
Contributor
Author
|
Note this code needs updates similar to:
|
Contributor
Author
|
Likewise need fix: #72 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the helm2 script check_and_deploy_helm.sh,
for clusters that have disabled NodePort but that do have cluster ingress enabled,
detect and update a Kubernetes Ingress resource with values reflecting the cluster ingress configuration.
Roughly, the steps are
if the Helm chart values has:
ingressthen set:
ingress.enabled=trueand replace chart strings
cluster-ingress-subdomainandcluster-ingress-secretwith the respective cluster ingress host and cluster ingress secret.
That is, for each host at a path like
ingress.hosts[0]that has a value like
"hello-app.cluster-ingress-subdomain",change it to a value like
"hello-app.example.com".For each tls host at a path like
ingress.tls[0].hosts[0]that has a value like
"hello-app.cluster-ingress-subdomain",change it to a value like
"hello-app.example.com".For each tls secret at a path like
ingress.tls[0].secretNamethat has a value like
"cluster-ingress-secret",change it to a value like
"example-tls-secret".Related to the proposed changes in the hello-helm repo:
https://github.com/open-toolchain/hello-helm/pull/5
Also related to the similar previous change for non-Helm kubectl deploys:
Add ingress processing for kubernetes cluster #65