feat(bitcoin): add PSBT signing via sign_transaction#201
Open
dolepee wants to merge 3 commits intoopen-wallet-standard:mainfrom
Open
feat(bitcoin): add PSBT signing via sign_transaction#201dolepee wants to merge 3 commits intoopen-wallet-standard:mainfrom
dolepee wants to merge 3 commits intoopen-wallet-standard:mainfrom
Conversation
|
@dolepee is attempting to deploy a commit to the MoonPay Team on Vercel. A member of the Team first needs to authorize it. |
njdawn
requested changes
Apr 15, 2026
Contributor
njdawn
left a comment
njdawn
left a comment
There was a problem hiding this comment.
LGTM -> after CI fixes + merge conflicts can merge
Detects PSBT format by magic bytes inside BitcoinSigner::sign_transaction, keeping the ChainSigner trait chain-agnostic with no new methods. Supports P2WPKH inputs, skips inputs not owned by the signing key. Signed PSBT bytes are returned in SignOutput::signature.
dolepee
force-pushed
the
feat/bitcoin-psbt-via-sign-transaction
branch
from
44cd19e to
a49e546
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Bitcoin PSBT (BIP-174) signing support through the existing `sign_transaction` interface, keeping the `ChainSigner` trait chain-agnostic (no new trait methods).
`BitcoinSigner::sign_transaction` detects PSBT format by magic bytes (`psbt\xff`) and routes to PSBT handling automatically. Non-PSBT transactions continue through the existing double-SHA256 path.
What it does
Changes
Design note
Per feedback on #137, this avoids adding any Bitcoin-specific method to the `ChainSigner` trait. PSBT is handled as an implementation detail of `BitcoinSigner` behind the same `sign_transaction` entry point all chains use.
Verification