Add defaultEventSource to WorkflowApplication#1556
Open
matheusandre1 wants to merge 1 commit into
Open
Conversation
Collaborator
|
@matheusandre1 you must sign your commits with |
Contributor
Author
Sorry, I always forget about that. |
fjtirado
reviewed
Jul 22, 2026
fjtirado
left a comment
fjtirado
left a comment
Collaborator
There was a problem hiding this comment.
@matheusandre1
Lets make default event source a WorkflowValueResolver, so it returns an URI from the WorkflowContext, TaskContext and Model
Signed-off-by: Matheus André <matheusandr2@gmail.com>
fjtirado
reviewed
Jul 23, 2026
fjtirado
reviewed
Jul 23, 2026
fjtirado
reviewed
Jul 23, 2026
fjtirado
reviewed
Jul 23, 2026
fjtirado
reviewed
Jul 23, 2026
fjtirado
reviewed
Jul 23, 2026
fjtirado
reviewed
Jul 23, 2026
Comment on lines
+40
to
+42
| List<CloudEvent> events = Collections.synchronizedList(new ArrayList<>()); | ||
| InMemoryEvents broker = new InMemoryEvents(); | ||
| broker.register(eventType, events::add); |
Collaborator
There was a problem hiding this comment.
There is a lot of duplicated code in these test, lets avoid copy paste and use "@beforeeach" annotation
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it: Closes: #1554
Special notes for reviewers:
Additional information (if needed):