Skip to content

Ingest KibblesTasty spells#858

Open
somanyrobots wants to merge 18 commits intoopen5e:stagingfrom
somanyrobots:kibbles-spells
Open

Ingest KibblesTasty spells#858
somanyrobots wants to merge 18 commits intoopen5e:stagingfrom
somanyrobots:kibbles-spells

Conversation

@somanyrobots
Copy link

@somanyrobots somanyrobots commented Jan 12, 2026

Adding KibblesTasty spells from KCCC and KCLL; had to reopen the PR because it wouldn't rebase cleanly on all the staging changes I hadn't copied over.

All these spells are CC-BY-licensed (even though they're in paid books) and have express permission from the creator to import.

@somanyrobots somanyrobots marked this pull request as draft January 12, 2026 07:25
@somanyrobots somanyrobots changed the title Kibbles spells Ingest KibblesTasty spells Jan 12, 2026
@somanyrobots
Copy link
Author

This is now passing tests, but still not producing totally correct outputs; I'll mark as ready once I'm done QA'ing and regenerating.

@somanyrobots somanyrobots marked this pull request as ready for review February 14, 2026 07:49
@somanyrobots
Copy link
Author

okay, I think this is good to go - I reviewed all the spellcasting options, tweaked the scripts, and fixed a dozen or so by hand that weren't worth the trouble to adjust the scripts for.

Copy link
Contributor

@calumbell calumbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @somanyrobots, thanks for getting this PR submitted. Obviously kind of difficult to QC all the spells included in here, but those I looked at on my cursory spot check all looked good to me.

These are a couple of changes it would be good to resolve before we get this merged.

  1. I see that you have added stubs for new classes, but all the class feature data for these is missing. Could we either:
  • (A) Remove the references to these classes from the Spell "classes" field until they are implemented.
  • (B) Add in the missing ClassFeature and ClassFeatureItem data required to complete these classes (which is a fair bit of work, i'd be happy to offer a hand)
  1. The key fields for the new Document data look a bit strange. The schema for appreviated the title appears to be mixed. Lets pick one scheme and run with it:
  • (A) kibbles-krd, kibbles-ccc, kibbles-cll
  • (B) krd, kcc, kll
  • (C) kibbles-krd, kibbles-cc, kibbles-ll

Thanks again for your contribution! Let me know if you have any questions

@somanyrobots
Copy link
Author

alright, made the easy change. I'll take a crack at the hard change - parsing the class data out of the foundry module is actually probably easier than the spells were, I won't need the same regex forest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants