Skip to content

Add ability to filter monsters by environment #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
calumbell merged 1 commit into from
Feb 26, 2026
Merged

Add ability to filter monsters by environment #884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ pipenv run python manage.py spectacular --color --file openapi-schema.yml` to bu
```

# Contributing
See [contribution guide](CONTRIBUTING.md).
See [contribution guide](.github/CONTRIBUTING.md).
# Tests

Tests are located in the `api/tests` directory. These should be run before pushing new changes to the main repository. These tests require that the api is [running](##run) at `http://localhost:8000`.
Expand Down
5 changes: 5 additions & 0 deletions api/filters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,10 @@ class Meta:


class MonsterFilter(CommonFilterSet):
environments = django_filters.CharFilter(
field_name="environments_json", lookup_expr="icontains"
)

class Meta:
model = models.Monster
fields = {
Expand All @@ -91,6 +95,7 @@ class Meta:
"hit_points": ["exact", "range", "gt", "gte", "lt", "lte"],
"armor_class": ["exact", "range", "gt", "gte", "lt", "lte"],
"type": ["iexact", "exact", "in", "icontains"],
"environments_json": ["iexact", "exact", "in", "icontains"],
"size": ["iexact", "exact", "in", "icontains"],
"page_no": ["exact", "range", "gt", "gte", "lt", "lte"],
"document__slug": [
Expand Down