Closed
Conversation
Contributor
Author
|
Closing and re-opening to re-run validation |
Contributor
Author
|
Hmm, struggling to get debug mode and dev dependencies playing nicely today. Will close for now and have a think |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the Django Debug Toolbar to Open5e as a development dependency. It is only configured to appear when the
"DEBUG"flag inserver/settings.pyis set to True.I have used the DDT on my local fork for some time now, and it has been really helpful for resolving N+1 errors that occasionally crop up.
Related Issues
Closes #881
How was this tested
N.B. local tests are failing on this branch due to issue #885. It would be preferred if PR #886 (which fixes the bug) were merged first to avoid this causing any confusion.