update missing plural labels in property vocab#85
Merged
Raphael-Gazzotti merged 5 commits intomainfrom Mar 11, 2026
Merged
Conversation
apdavison
requested changes
Mar 10, 2026
| "label": "Leg lengths", | ||
| "labelPlural": null, | ||
| "labelPlural": "Leg lengths", | ||
| "name": "legLengths", |
Member
There was a problem hiding this comment.
why do we have a name that is already a plural? (especially given that "legLength" is defined above)
Member
Author
There was a problem hiding this comment.
we defined a while ago that properties that expect always at minimum 2 entries the property name is plural (cf. coordinates)
Member
Author
There was a problem hiding this comment.
we can target that issue in the next round; for now let's stick to what we defined in the past
Co-authored-by: Andrew Davison <andrew.davison@cnrs.fr>
Co-authored-by: Andrew Davison <andrew.davison@cnrs.fr>
| "labelPlural": "Intermediate diameters", | ||
| "name": "intermediateDiameter", | ||
| "namePlural": null, | ||
| "namePlural": "intermediateDiameter", |
Raphael-Gazzotti
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.