susepaste: handle multiple login sessions#25
Open
tacerus wants to merge 1 commit into
Open
Conversation
The script would return something like ``` Failed to get path for session '1 2': No session '1 2' known Graphics server not found. Copying to clipboard is not possible. ``` if multiple login sessions matching the username are found. This is mostly caused by the list-sessions output being passed to the show-session query including line breaks. Repair this by: - querying only seat sessions, those are most likely to be graphical - stopping after the first match, instead of adding line breaks and additional session IDs to the type query (show-session does support passing multiple session IDs, but our case-logic would not handle the result) This might still be error prone, as someone could theoretically have multiple graphical sessions with a mix of X11 and Wayland launched, but I deem it already better than not handling multiple active login sessions at all. Signed-off-by: Georg Pfuetzenreuter <mail@georg-pfuetzenreuter.net>
Member
Author
|
Amended to use search for seat instead of tty. |
|
As I already said on mailing list, you don't even need the session number. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The script would return something like
if multiple login sessions matching the username are found. This is mostly caused by the list-sessions output being passed to the show-session query including line breaks.
Repair this by:
graphical
and additional session IDs to the type query (show-session does
support passing multiple session IDs, but our case-logic would
not handle the result)
This might still be error prone, as someone could theoretically have multiple graphical sessions with a mix of X11 and Wayland launched, but I deem it already better than not handling multiple active login sessions at all.