[codex] Split RTL compatibility samples into stacked PR#68
Merged
omers-oai merged 2 commits intocodex/rtl-compatibilityfrom Mar 27, 2026
Merged
Conversation
omers-oai
force-pushed
the
codex/rtl-compatibility-samples-only
branch
4 times, most recently
from
b58d2d4 to
ab54d55
Compare
omers-oai
force-pushed
the
codex/rtl-compatibility-samples-only
branch
3 times, most recently
from
35f24ad to
7cb1662
Compare
omers-oai
force-pushed
the
codex/rtl-compatibility-samples-only
branch
from
7cb1662 to
6dff7c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex: This stacks on #63 and moves the Android sample and preview updates into their own review surface.
What changed
android-sample#63focused on the library behavior, tests, and rendering code onlyWhy
The main RTL compatibility PR had both core behavior changes and a large sample/demo diff. Splitting the sample files into a stacked PR makes the review path smaller and keeps the library logic easier to inspect.
Impact
#63already containscodex/rtl-compatibilityTesting
./gradlew :android-sample:testDebugUnitTest :android-sample:recordRoborazziDebug