Closed
Conversation
tananaev
reviewed
Apr 6, 2026
| appendInlineContent(content = InlineContent { | ||
| HtmlBlock(astNodeType.literal) | ||
| if (richTextRenderOptions.enableRtlCompatibility) { | ||
| HtmlBlock(astNodeType.literal) |
Member
There was a problem hiding this comment.
Is there a reason we don't just always do this?
Author
There was a problem hiding this comment.
Unclear if this actually fixes something, but the goal here was to minimize the changes to an experiment so we if some weird case breaks it we have control to back it up.
I'm going to close this, since Codex wrongly thought another PR broke something, but it did not and this is not needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex: Fix centered HTML rendering in RTL compatibility mode.
What changed
AstHtmlBlockdirectly as block content instead of wrapping it in inline placeholder contentWhy
Impact
enableRtlCompatibility = trueTesting
./gradlew :android-sample:testDebugUnitTest --console=plain./gradlew :android-sample:recordRoborazziDebug --console=plain./gradlew :richtext-markdown:allTests --console=plain./gradlew :android-sample:testDebugUnitTest :richtext-markdown:allTests --console=plain