Skip to content

[codex] Avoid intrinsic sizing for RTL markdown documents#70

Closed
omers-oai wants to merge 1 commit intomainfrom
codex/rtl-markdown-document-sizing
Closed

[codex] Avoid intrinsic sizing for RTL markdown documents#70
omers-oai wants to merge 1 commit intomainfrom
codex/rtl-markdown-document-sizing

Conversation

@omers-oai
Copy link
Copy Markdown

Codex:

Summary

  • Replaced the RTL markdown document IntrinsicSize.Max wrapper with an internal measurement pass that uses real child measurement instead of intrinsic measurement.
  • Added a generated Roborazzi preview case for a markdown table rendered with RTL compatibility enabled.
  • Passed render options through the RTL behavior preview helper so the table regression path stays explicit.

Root cause

  • The RTL document wrapper asked the whole markdown tree for intrinsic width. Markdown tables render through SubcomposeLayout, which cannot answer intrinsic measurement, and future subcomposed block nodes would have the same problem.

Testing

  • ./gradlew :android-sample:recordRoborazziDebug :android-sample:testDebugUnitTest
  • ./gradlew :android-sample:testDebugUnitTest :richtext-markdown:allTests
  • ./gradlew check

Co-authored-by: Codex <noreply@openai.com>
@omers-oai omers-oai closed this Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant