[codex] Expose shared bidi direction detection#74
Closed
Conversation
80cea0c to
cd70bb5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex: This lifts the first-strong bidi scanner into richtext-ui so both markdown rendering and other UI surfaces can share the same direction rule instead of copying it.
Testing
BUILD SUCCESSFUL in 1s
93 actionable tasks: 2 executed, 91 up-to-date
BUILD SUCCESSFUL in 1s
115 actionable tasks: 4 executed, 111 up-to-date