-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Main #1787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kristentr
wants to merge
12
commits into
openai:master
Choose a base branch
from
kristentr:main
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Main #1787
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
c07bc05
chore(deps): bump basic-ftp in /ecosystem-tests/browser-direct-import
dependabot[bot] 8a7ae86
Merge pull request #11 from kristentr/dependabot/npm_and_yarn/ecosyst…
kristentr e8d2c18
chore(internal): refactor imports
stainless-app[bot] a18ba50
refactor(tests): switch from prism to steady
stainless-app[bot] d1094c5
chore(tests): bump steady to v0.19.4
stainless-app[bot] ec23de8
feat(client): add async iterator and stream() to WebSocket classes
stainless-app[bot] 5b2c630
chore(tests): bump steady to v0.19.5
stainless-app[bot] 647b11a
Release please branches master changes next components OpenAI (…
kristentr 9a9f7cf
Release please branches master changes next components OpenAI (…
kristentr 7165d84
Merge pull request #24 from kristentr/master
kristentr 09c953b
chore(deps): bump seroval and solid-js in /ecosystem-tests/vercel-edg…
kristentr 1855e23
Main (#26) (#27)
kristentr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| { | ||
| ".": "6.32.0" | ||
| ".": "6.33.0" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a caller exits
for await (const event of ws.stream())early and intentionally keeps the socket open—as the docstring says is allowed—return()removes the iterator’s temporary'error'listener immediately. Any later API/socket error on that still-live connection will then fall back toResponsesEmitter._onError()'s no-listener path ininternal-base.ts, surfacing as an unhandled rejection. In practice this makes the async-iterator API unsafe to use by itself unless callers also remember to bindws.on('error')or close the socket before breaking.Useful? React with 👍 / 👎.