fix: coerce numeric API error codes to strings - #3543
Open
nightcityblade wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes being requested
Normalize non-null API error codes to strings when constructing
APIError, so the runtime value matches the documentedstr | Nonecontract even when an endpoint or compatible gateway returns a numeric JSON code.Add a focused regression test covering a numeric
404error code.Fixes #3531
Additional context & links
Validation:
.venv/bin/python -m pytest tests/test_exceptions.py -q.venv/bin/ruff check src/openai/_exceptions.py tests/test_exceptions.py.venv/bin/ruff format --check src/openai/_exceptions.py tests/test_exceptions.py.venv/bin/mypy src/openai/_exceptions.py