Skip to content

Modal/SemiModalのDesignDocを追加し、Figma Code Connectを追加#1725

Open
yu-3in wants to merge 3 commits intomainfrom
codex/create-design-document-for-modal
Open

Modal/SemiModalのDesignDocを追加し、Figma Code Connectを追加#1725
yu-3in wants to merge 3 commits intomainfrom
codex/create-design-document-for-modal

Conversation

@yu-3in
Copy link
Copy Markdown
Contributor

@yu-3in yu-3in commented Dec 19, 2025 •
edited
Loading

DialogのDesignDocを参考に書いてます。

Summary

  • SemiModalの用途や構成要素、利用例をまとめたデザインドキュメントを追加しました
  • サイズ・タイプごとの挙動、カスタマイズ用CSS変数、アクセシビリティ観点を整理しました

Testing

  • テストなし（ドキュメントのみ）

Codex Task

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Dec 19, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3a4b4fc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 19, 2025 •
edited
Loading

Visit the preview URL for this PR (updated for commit 3a4b4fc):

https://ameba-spindle--pr1725-codex-create-design-lbrxhonz.web.app

(expires Sun, 18 Jan 2026 10:37:12 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e7521619a2dd5c653490c8246e81ec2a5c8f1435

@reg-suit
Copy link
Copy Markdown

reg-suit Bot commented Dec 19, 2025 •
edited
Loading

✨✨ That's perfect, there is no visual difference! ✨✨

Check out the report here.

@yu-3in yu-3in changed the title SemiModalのデザインドキュメントを追加 SemiModalのDesignDocを追加 Dec 19, 2025
@yu-3in yu-3in changed the title SemiModalのDesignDocを追加 Modal/SemiModalのDesignDocを追加 Dec 19, 2025
@yu-3in yu-3in changed the title Modal/SemiModalのDesignDocを追加 Modal/SemiModalのDesignDocを追加し、Figma Code Connectを追加 Dec 19, 2025
yasuda-shin
yasuda-shin reviewed Dec 26, 2025
View reviewed changes
Comment thread packages/spindle-ui/src/Modal/SemiModal/design-doc.md

HTMLDialogElementを基盤にしており、`open`プロパティの変更に応じて`showModal()` / `close()`を呼び出します。オーバーレイクリックやEscキー入力を検知して`onClose`を発火するため、呼び出し元で状態を同期してください。

## スクリーンショット
Copy link
Copy Markdown
Contributor

@yasuda-shin yasuda-shin Dec 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

スクリーンショット不要ですかね？

@yasuda-shin
Copy link
Copy Markdown
Contributor

yasuda-shin commented Dec 26, 2025

Modalってテストないんですね😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yasuda-shin yasuda-shin yasuda-shin left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@yu-3in yu-3in

Labels

codex

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yu-3in @yasuda-shin