Support non standard http codes#1407
Open
Ykrej wants to merge 11 commits into
Open
Conversation
3 tasks
sergioestebance
added a commit
to langwatch/langwatch
that referenced
this pull request
May 29, 2026
…T client Cloudflare (520-527), AWS WAF (561), and other proxies return status codes outside Python's http.HTTPStatus enum. The upstream openapi-python-client template blindly calls HTTPStatus(response.status_code) in _build_response, which raises ValueError on those codes and crashes every endpoint call. Customer report: Cloudflare 520 from get_api_prompts_by_id. Fix: - Add safe_http_status() helper in types.py that falls back to int on ValueError - Widen Response.status_code type from HTTPStatus to HTTPStatus | int - Override openapi-python-client Jinja templates (openapi-templates/) so future regenerations preserve the fix; wire --custom-template-path in Makefile - Apply the patch to all 90 already-generated endpoint files in place - Regression test for 520, 561, 499 and IANA codes Tracked upstream: openapi-generators/openapi-python-client#1407
sergioestebance
added a commit
to langwatch/langwatch
that referenced
this pull request
May 29, 2026
…T client Cloudflare (520-527), AWS WAF (561), and other proxies return status codes outside Python's http.HTTPStatus enum. The upstream openapi-python-client template blindly calls HTTPStatus(response.status_code) in _build_response, which raises ValueError on those codes and crashes every endpoint call. Customer report: Cloudflare 520 from get_api_prompts_by_id. Fix: - Add safe_http_status() helper in types.py that falls back to int on ValueError - Widen Response.status_code type from HTTPStatus to HTTPStatus | int - Override openapi-python-client Jinja templates (openapi-templates/) so future regenerations preserve the fix; wire --custom-template-path in Makefile - Apply the patch to all 90 already-generated endpoint files in place - Regression test for 520, 561, 499 and IANA codes Tracked upstream: openapi-generators/openapi-python-client#1407
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added support for responses with non-standard HTTP Status Codes. Off by default, enabled with
allow_int_response_codes.Problem
Currently if a response with a status code that does not exist in
http.HTTPStatusCodeaValueErroris raised. For example:ValueError: 490 is not a valid HTTPStatus.Edge Case
If a non-standard status code is received from an endpoint that doesn't define any responses with non-standard status codes the old behavior will appear.